Skip to content

Commit

Permalink
chore: pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Conrad Chan committed May 13, 2021
1 parent bf487ec commit 6e62929
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/lib/viewers/controls/icons/IconVr24.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ function IconVr24(props: React.SVGProps<SVGSVGElement>): JSX.Element {
return (
<svg focusable={false} height={24} viewBox="0 0 24 24" width={24} {...props}>
<g fill="none" fillRule="evenodd">
<path d="M0 0h24v24H0V0z" />
<path
d="M2.045 17.25c1.114 1.296 5.66 1.487 7.033.268 1.374-1.22 1.367-1.733 2.972-1.733 1.692 0 1.436-.02 3.122 1.732 1.687 1.752 5.973.84 6.9-.268.927-1.11 1.507-7.72 0-10.038-1.507-2.317-18.38-2.25-20.027 0-1.647 2.252-1.114 8.74 0 10.037z"
stroke="#FFF"
Expand Down
8 changes: 6 additions & 2 deletions src/lib/viewers/controls/model3d/VrToggleControl.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,13 @@ export type Props = {
};

export default function VrToggleControl({ isVrShown, onVrToggle }: Props): JSX.Element | null {
return isVrShown ? (
if (!isVrShown) {
return null;
}

return (
<button className="bp-VrToggleControl" onClick={onVrToggle} title={__('box3d_toggle_vr')} type="button">
<IconVr24 />
</button>
) : null;
);
}

0 comments on commit 6e62929

Please sign in to comment.