Skip to content

Commit

Permalink
feat(archive-viewer): address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Mingze Xiao committed Dec 17, 2019
1 parent e13a762 commit 21b56e3
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
6 changes: 1 addition & 5 deletions src/lib/viewers/archive/ArchiveExplorer.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,7 @@ class ArchiveExplorer extends React.Component {
<Internationalize language="en-us" messages={{}}>
<div className="bp-ArchiveExplorer">
<Breadcrumbs fullPath={fullPath} onClick={this.handleClickFullPath} view={view} />
<VirtualizedTable
className="ArchiveFilesTable"
rowData={itemList}
rowGetter={this.getRowData(itemList)}
>
<VirtualizedTable rowData={itemList} rowGetter={this.getRowData(itemList)}>
{intl => [
<Column
key={KEY_NAME}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/viewers/archive/Breadcrumbs.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class Breadcrumbs extends React.PureComponent {
const { fullPath, onClick, view } = this.props;

return (
<div className="bp-header-breadcrumbs">
<div className="bp-Breadcrumbs">
<Breadcrumb>
{view === VIEWS.VIEW_SEARCH ? (
<span>{__('search_results')}</span>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/viewers/archive/Breadcrumbs.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@import '~box-ui-elements/es/styles/variables';

.bp-header-breadcrumbs {
.bp-Breadcrumbs {
display: flex;
flex: 0 0 50px;
align-items: center;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('lib/viewers/archive/Breadcrumbs', () => {
it('should render correct components', () => {
const component = shallow(<Breadcrumbs fullPath={fullPath} onClick={onClick} view={view} />);

expect(component.find('.bp-header-breadcrumbs').length).to.equal(1);
expect(component.find('.bp-Breadcrumbs').length).to.equal(1);
expect(component.find('InjectIntl(Breadcrumb)').length).to.equal(1);
expect(component.find('PlainButton').length).to.equal(2);
});
Expand Down

0 comments on commit 21b56e3

Please sign in to comment.