Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace uglify with terser #713

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

jaknas
Copy link
Contributor

@jaknas jaknas commented May 29, 2024

This PR replaces deprecated uglifyjs-webpack-plugin in favor of terser-webpack-plugin. Running uglify causes build to error with:

ERROR in annotations.js from UglifyJs
Unexpected token: keyword «const» [annotations.js:831,0]

when running with box-ui-elements@19 and later.

NOTE: I wasn't able to run this build and verify if it still works yet. Annotations seem to work as before when testing locally with yarn link.

@CLAassistant
Copy link

CLAassistant commented May 29, 2024

CLA assistant check
All committers have signed the CLA.

@jaknas jaknas force-pushed the update-to-terser branch from 8a3fd7b to 5b1b3ae Compare May 29, 2024 15:35
@jaknas jaknas marked this pull request as ready for review May 29, 2024 16:01
@jaknas jaknas requested a review from a team as a code owner May 29, 2024 16:01
jstoffan
jstoffan previously approved these changes May 29, 2024
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this result in any meaningful changes to the production bundle?

@jaknas
Copy link
Contributor Author

jaknas commented Jun 5, 2024

Did this result in any meaningful changes to the production bundle?

I don't see any jumping out. Only differences I see are those that'd be expected when changing minifier: changes in 1-character variable names, changes in how expressions are being written down.

@jstoffan jstoffan merged commit 3ea3fea into box:master Jun 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants