-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade react-intl lib #709
Conversation
I have to add resolution for react-intl to package.json file ( "/react-intl//@types/react": "^17.0.2"). react-intl has set @types/react to version 16 || 17 || 18 (https://github.com/formatjs/formatjs/blob/main/package.json#L61) so yarn install the latest one, however @types/react 17 i 18 are incompatible. It caused a mismatch of types in some components. |
I removed redundant |
Regarding
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from an i18n point of view. Still needs product team's approval as well.
@@ -94,7 +94,7 @@ | |||
"raw-loader": "^4.0.1", | |||
"react": "^17.0.1", | |||
"react-dom": "^17.0.1", | |||
"react-intl": "^3.12.0", | |||
"react-intl": "6.4.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this exact version or can we prefix with a caret?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not 100% sure. Normally, we should use a caret. However, I discovered that react-intl version 6.4 specifies TypeScript version 4 in peerDependencies, while react-intl 6.5 requires TypeScript version 5. I am concerned that this might cause some issues, that is why I used exact version. I think they should update the react-intl package version to 7 when making this change, but they haven't done so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thank you for the explanation. Should we bump to 6.4.7, in that case?
@soygitana, this is good to merge as-is if we don't want to mess with the patch version bump right now. |
❗ On hold: BUIE should go first, then Preview and Annotations (confirmed by @greg-in-a-box) |
IMPORTANT:
Changes:
react-intl
lib has been upgrade to v6.4.2Testing:
Make sure application and strings are not broken when language is changed.
For more information, please check: