Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Fix cannot redefine property: window errors #705

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

bkepka-box
Copy link
Contributor

After Node 18 upgrade there are some errors occurring. Upgrading jest-canvas-mock seems to fix the problem.
Screenshot 2023-09-20 at 10 55 42

@bkepka-box bkepka-box requested a review from a team as a code owner September 20, 2023 11:18
jstoffan
jstoffan previously approved these changes Sep 20, 2023
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using chore for the commit message, since this doesn't fix a bug with the production code.

package.json Outdated Show resolved Hide resolved
@bkepka-box bkepka-box changed the title fix(tests): Fix cannot redefine property: window errors chore(tests): Fix cannot redefine property: window errors Sep 25, 2023
@bkepka-box bkepka-box merged commit c61e473 into box:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants