fix(accessibility): Add accessible name for ReplyField #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bkepka-box
commented
Sep 18, 2023
bkepka-box
commented
JChan106
reviewed
Sep 19, 2023
| @@ -10,6 +10,8 @@ ba.annotationsPost = Post | |||
| ba.annotationsSave = Save | |||
| # Aria label description for reply popup | |||
| ba.popup.reply.comment = Comment | |||
| # Aria label description for annotation comment field | |||
| ba.popup.reply.field = Type a comment | |||
There was a problem hiding this comment.
Was this message given by the accessibility or messaging team? If not do we need to add something more specific like "Type an annotation comment"?
There was a problem hiding this comment.
@JChan106 Actually it was not given, I put it like this because it is the same as placeholder for the input field which is used in aria-describedby (can be seen on the screenshot). Should I change it to the "Type an annotation comment"?
There was a problem hiding this comment.
Hm I see, I think it should be okay then if that's the case
JChan106
approved these changes
Sep 21, 2023
| @@ -10,6 +10,8 @@ ba.annotationsPost = Post | |||
| ba.annotationsSave = Save | |||
| # Aria label description for reply popup | |||
| ba.popup.reply.comment = Comment | |||
| # Aria label description for annotation comment field | |||
| ba.popup.reply.field = Type a comment | |||
There was a problem hiding this comment.
Hm I see, I think it should be okay then if that's the case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.