feat(node-18-upgrade): Upgrade to node 18 #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelee7
reviewed
Jul 27, 2023
package.json
Outdated
| @@ -55,7 +55,7 @@ | |||
| "babel-plugin-react-intl": "^7.5.1", | |||
| "babel-plugin-transform-require-ignore": "^0.1.1", | |||
| "box-node-sdk": "^1.33.0", | |||
| "box-ui-elements": "^15.0.0-beta.6", | |||
| "box-ui-elements": "18.1.0", | |||
There was a problem hiding this comment.
Is the ^ removed on purpose? Do we need this exact version of BUIE?
There was a problem hiding this comment.
Hm good point, I referenced how box-content-preview used BUIE, and it seems like it didn't use ^, so I followed the same principle. I don't see an issue with just freezing the major version, since it is a dependency we trust. Updated
jstoffan
requested changes
Jul 28, 2023
package.json
Outdated
| @@ -154,5 +153,8 @@ | |||
| }, | |||
| "resolutions": { | |||
| "uglify-es": "3.3.4" | |||
| }, | |||
| "dependencies": { | |||
| "sass": "^1.64.1" | |||
There was a problem hiding this comment.
Can we move this to devDependencies? Otherwise, it will be included as a transitive dependency by its consumers.
There was a problem hiding this comment.
Ah my mistake, will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to upgrade box-annotations to use node 18. This requires replacing node-sass with sass, similar to the upgrades in box-content-preview and BUIE. We did not split this into a separate PR because that upgrade requires node 14+, so instead of upgrading to node 14 in another PR and then node 18 in this PR, we decided to upgrade them at once.
This upgrade to node 18 is similar to the upgrade for box-content-preview. We use the same workaround BUIE and box-content-preview use for the OpenSSL issue.