Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): for "Type a comment…" dialog #700

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

arturfrombox
Copy link
Contributor

@arturfrombox arturfrombox commented Jul 12, 2023

Description of Changes

  • WCAG 2.0 Level A - 1.3.1 Info and Relationships - Medium Impact. Draft editor component should indicate whether it can accepts multiple lines of input, so aria-multiline="true" was added.
  • WCAG 2.0 Level A - 2.1.1 Keyboard - Serious Impact. The "Type a comment…" dialog did not manage keyboard focus correctly. It should be maintaining focus within the dialog and removing focus from the rest of the page . So the tabIndex and focus traps were added. (ref. https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/dialog/)
  • WCAG 2.0 Level A - 4.1.2 Success Criterion - Medium Impact. The "Type a comment…" dialog should be presented as a dialog, so the role="dialog" attribute was added. Also interactive popup button received an aria-haspopup attribute in order to indicate that dialog element can be triggered by the button.

@arturfrombox arturfrombox requested a review from a team as a code owner July 12, 2023 10:40
src/components/Popups/PopupReply.tsx Show resolved Hide resolved
src/components/Popups/PopupReply.tsx Outdated Show resolved Hide resolved
src/components/Popups/PopupReply.tsx Outdated Show resolved Hide resolved
i18n/en-US.properties Outdated Show resolved Hide resolved
@arturfrombox
Copy link
Contributor Author

@jstoffan thanks for taking a look, I updated the PR

@patlm patlm merged commit 2389c85 into box:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants