fix(reply): Fix at mention list misaligned after window resize #678
Conversation
mxiao6
commented
Jan 28, 2021
mxiao6
commented
- unit test
- cross-browser testing
| @@ -58,6 +58,10 @@ export default class ReplyField extends React.Component<Props, State> { | |||
| fetchCollaborators(trimmedQuery); | |||
| }, DEFAULT_COLLAB_DEBOUNCE); | |||
|
|
|||
| componentDidMount(): void { | |||
| window.addEventListener('resize', this.updatePopupReference); | |||
There was a problem hiding this comment.
Should this be debounced? Does this conflict with preview's resize handling at all?
There was a problem hiding this comment.
I don't think debounce is needed here since we don't need to catch the new dimensions. We just trigger a popper update, it shouldn't conflict with preview's resize handling.
There was a problem hiding this comment.
Hm, it looks like calling this.updatePopupReference triggers a setState and also a bunch of logic to get data from the DOM via getVirtualElement. How can we come to further certainty regarding "shouldn't" on the above?
There was a problem hiding this comment.
One possible conflict that might crop up could be caused by the Preview SDK's own debounced resize handler. Is it possible that the following re-render in the Preview SDK could occur after the resize handler in Annotations? Would that cause the popup to be mispositioned? There may be other examples, such as resize handlers in BUIE.
mxiao6
force-pushed
the
fix-at-mention
branch
2 times, most recently
from
db59dcb to
6b432bf
Compare
mxiao6
force-pushed
the
fix-at-mention
branch
from
6b432bf to
9363b6e
Compare
