Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drawing): fix Add Comment text wrapping in Safari #673

Merged
merged 1 commit into from
Jan 20, 2021
Merged

fix(drawing): fix Add Comment text wrapping in Safari #673

merged 1 commit into from
Jan 20, 2021

Conversation

ChenCodes
Copy link
Contributor

@ChenCodes ChenCodes commented Jan 19, 2021 •
edited
Loading

Main Issue:
Screen Shot 2021-01-19 at 2 44 18 PM

  • In Safari, the Add Comment text was being incorrectly wrapped due to the width: auto attribute on the button style. The fix is to use max-content instead.
  • Cross browser testing

IE
ie

Edge
edge

Firefox
firefox

Chrome
chrome

Safari
safari

@ChenCodes ChenCodes requested a review from a team as a code owner January 19, 2021 23:14
ConradJChan
ConradJChan reviewed Jan 19, 2021
View reviewed changes
Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would updating the flex-shrink also fix this?

@ChenCodes
Copy link
Contributor Author

Would updating the flex-shrink also fix this?

It doesn't look like adding flex-shrink would fix it.

@ChenCodes ChenCodes merged commit 3cdd393 into box:master Jan 20, 2021
@ChenCodes ChenCodes deleted the add-comment-text-incorrect-wrap-on-safari branch January 20, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan left review comments

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChenCodes @jstoffan @ConradJChan