Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(drawing): Add drawing paths #632

Merged
merged 3 commits into from
Nov 20, 2020
Merged

feat(drawing): Add drawing paths #632

merged 3 commits into from
Nov 20, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Nov 11, 2020 •
edited
Loading

  • Unit test
  • Cross-browser testing

jstoffan
jstoffan reviewed Nov 12, 2020
View reviewed changes
src/drawing/drawingUtil.ts Outdated Show resolved Hide resolved
src/drawing/DrawingTarget.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingTarget.scss Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
ConradJChan
ConradJChan reviewed Nov 12, 2020
View reviewed changes
src/drawing/DrawingList.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingTarget.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingTarget.tsx Outdated Show resolved Hide resolved
@mxiao6 mxiao6 force-pushed the drawing-paths branch 3 times, most recently from c5d47e5 to 59f64fd Compare November 17, 2020 07:19
ConradJChan
ConradJChan reviewed Nov 17, 2020
View reviewed changes
src/drawing/DrawingList.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingTarget.scss Show resolved Hide resolved
jstoffan
jstoffan reviewed Nov 17, 2020
View reviewed changes
src/drawing/DrawingList.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingList.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingTarget.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
ConradJChan
ConradJChan reviewed Nov 17, 2020
View reviewed changes
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPath.tsx Outdated Show resolved Hide resolved
jstoffan
jstoffan reviewed Nov 17, 2020
View reviewed changes
src/drawing/DrawingPathGroup.scss Outdated Show resolved Hide resolved
src/drawing/DrawingPathGroup.scss Outdated Show resolved Hide resolved
src/drawing/DrawingPathGroup.tsx Show resolved Hide resolved
src/drawing/DrawingTarget.tsx Outdated Show resolved Hide resolved
@mxiao6 mxiao6 marked this pull request as ready for review November 18, 2020 20:19
@mxiao6 mxiao6 requested a review from a team as a code owner November 18, 2020 20:19
jstoffan
jstoffan reviewed Nov 18, 2020
View reviewed changes
src/store/annotations/util.ts Outdated Show resolved Hide resolved
src/store/annotations/util.ts Outdated Show resolved Hide resolved
src/store/annotations/util.ts Outdated Show resolved Hide resolved
src/store/annotations/util.ts Outdated Show resolved Hide resolved
src/@types/model.ts Outdated Show resolved Hide resolved
src/drawing/DrawingPathGroup.tsx Outdated Show resolved Hide resolved
ConradJChan
ConradJChan reviewed Nov 18, 2020
View reviewed changes
src/drawing/DrawingPathGroup.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPathGroup.tsx Outdated Show resolved Hide resolved
src/drawing/DrawingPathGroup.tsx Outdated Show resolved Hide resolved
src/drawing/__tests__/DrawingPathGroup-test.tsx Outdated Show resolved Hide resolved
src/drawing/__tests__/DrawingPathGroup-test.tsx Outdated Show resolved Hide resolved
src/store/annotations/util.ts Outdated Show resolved Hide resolved
jstoffan
jstoffan reviewed Nov 19, 2020
View reviewed changes
src/store/annotations/reducer.ts Outdated Show resolved Hide resolved
src/store/annotations/reducer.ts Outdated Show resolved Hide resolved
ConradJChan
ConradJChan reviewed Nov 19, 2020
View reviewed changes
src/drawing/DrawingPath.tsx Show resolved Hide resolved
src/drawing/DrawingPath.tsx Show resolved Hide resolved
src/store/annotations/reducer.ts Outdated Show resolved Hide resolved
src/store/annotations/reducer.ts Outdated Show resolved Hide resolved
ConradJChan
ConradJChan reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/store/annotations/__tests__/reducer-test.ts Outdated Show resolved Hide resolved
ConradJChan
ConradJChan approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mergify mergify bot merged commit 937d901 into box:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstoffan jstoffan jstoffan left review comments

@ConradJChan ConradJChan ConradJChan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxiao6 @jstoffan @ConradJChan