Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(creator): Reset creator store when toggleAnnotationModeAction #620

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Oct 8, 2020

Whenever the toggleAnnotationModeAction is dispatched, we reset the creator store so that any previously staged annotation is cleared out.

Before
toggle region fail

After
toggle region success

@ConradJChan ConradJChan requested a review from a team as a code owner October 8, 2020 23:19
jstoffan
jstoffan previously approved these changes Oct 8, 2020
mxiao6
mxiao6 previously approved these changes Oct 8, 2020
@ConradJChan ConradJChan dismissed stale reviews from mxiao6 and jstoffan via 98978ce October 9, 2020 17:52
@ConradJChan ConradJChan force-pushed the reset-creator-on-mode-change branch from 64353a1 to 98978ce Compare October 9, 2020 17:52
@ConradJChan ConradJChan merged commit 294c3ff into box:master Oct 9, 2020
@ConradJChan ConradJChan deleted the reset-creator-on-mode-change branch October 9, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants