fix(highlight): Remove selection when clicking anywhere outside of popup #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mxiao6
commented
Oct 3, 2020
•
mxiao6
commented
- Unit tests
- Cross-browser testing
jstoffan
reviewed
Oct 3, 2020
mxiao6
force-pushed
the
fix-popuphighlight
branch
from
143c15e to
b2c7e2f
Compare
ConradJChan
reviewed
Oct 6, 2020
| @@ -54,8 +58,11 @@ export default function PopupHighlightError({ shape }: Props): JSX.Element { | |||
| }), | |||
| }; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |||
| useOutsideEvent('mousedown', popupRef.current?.popupRef!, onCancel); | |||
There was a problem hiding this comment.
Doesn't useOutsideEvent already expect a RefObject? Or is this to get at the underlying HTMLElement`
There was a problem hiding this comment.
Yeah, it needs the underlying HTMLElement.
mxiao6
force-pushed
the
fix-popuphighlight
branch
from
b2c7e2f to
2c03131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.