Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Enable drawingSelection & highlightMouseMove handlers for read-only permissions #61

Merged
merged 6 commits into from
Dec 8, 2017
Merged

Fix: Enable drawingSelection & highlightMouseMove handlers for read-only permissions #61

merged 6 commits into from
Dec 8, 2017

Conversation

pramodsum
Copy link
Contributor

No description provided.

@boxcla
Copy link

boxcla commented Dec 7, 2017

Verified that @pramodsum has signed the CLA. Thanks for the pull request!

JustinHoldstock
JustinHoldstock reviewed Dec 7, 2017
View reviewed changes
Copy link
Contributor

@JustinHoldstock JustinHoldstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the two this.isMobile checks? And only use this.hasTouch? I'm wondering how this would work on a desktop with a touchscreen interface

@pramodsum
Copy link
Contributor Author

I can remove this and all other relevant this.isMobile checks in a separate PR. That requires a larger testing on a Surface or similar devices.

@pramodsum pramodsum merged commit 33bda6a into box:master Dec 8, 2017
@pramodsum pramodsum deleted the highlights branch December 8, 2017 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinHoldstock JustinHoldstock JustinHoldstock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pramodsum @boxcla @JustinHoldstock