Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(highlight): Remove unnecessary Highlight Creator #608

Merged
merged 1 commit into from
Sep 30, 2020
Merged

fix(highlight): Remove unnecessary Highlight Creator #608

merged 1 commit into from
Sep 30, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Sep 30, 2020

No description provided.

@mxiao6 mxiao6 requested a review from a team as a code owner September 30, 2020 18:00
jstoffan
jstoffan previously approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be marked as a fix commit?

@mxiao6 mxiao6 force-pushed the remove-highlightCreator branch from 6e00629 to 4895522 Compare September 30, 2020 18:44
@mxiao6 mxiao6 changed the title chore(highlight): Remove unnecessary Highlight Creator fix(highlight): Remove unnecessary Highlight Creator Sep 30, 2020
@mergify mergify bot merged commit d8755d7 into box:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxiao6 @jstoffan