fix(ie): Remove selection type check #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will separate polyfill to a ts file. |
jstoffan
reviewed
Sep 2, 2020
src/document/docUtil.ts
Outdated
| } | ||
| } | ||
|
|
||
| export function isIE(): boolean { |
There was a problem hiding this comment.
Can this be avoided by checking for a different property on the selection and/or range(s)?
There was a problem hiding this comment.
I looked at Selection.prototype and Range.prototype in IE console and didn't find any similar property, unfortunately
There was a problem hiding this comment.
Is checking isCollapsed and rangeCount adequate? Can rangeCount be non-zero for a Caret selection?
There was a problem hiding this comment.
I actually think isCollapsed itself is adequate. rangeCount is 1 for Caret selection.
There was a problem hiding this comment.
I find rangeCount is 0 for None type selection. So yeah I think we can remove type check.
mxiao6
force-pushed
the
fix-windows-3
branch
from
eda38fb to
99e45e2
Compare
jstoffan
reviewed
Sep 2, 2020
mxiao6
changed the title
mxiao6
changed the title
jstoffan
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.