-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(highlight): Change cursor in Highlight Text mode #544
Conversation
mxiao6
commented
Jul 27, 2020
•
edited
Loading
edited
- Tests
4760fbb
to
ab9ec85
Compare
ab9ec85
to
f10c5be
Compare
|
||
// Construct a layer element where we can inject a root React component | ||
const rootLayerEl = documentEl.createElement('div'); | ||
rootLayerEl.classList.add('ba-Layer'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any concerns about rendering this layer even though the feature is not yet available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the toolbar highlight button is not clicked, we actually only render a <div />
with absolute positioning and pointer-event: none
. So I don't have any concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I think @ConradJChan had some concerns about rendering these components unconditionally, but I don't recall why. It should be okay for now, but we'll need to keep this in mind if we add anything else outside of the "creator" components.
jest.mock('../../common/withProviders'); | ||
jest.mock('../HighlightAnnotations'); | ||
|
||
describe('HighlightContainer', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we follow the path format here? I'd also be game for nuking the path entirely and just using the component name. Maintaining the path here seems tedious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will nuke the path entirely in the followup pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just make super sure there are no regressions for region annotations.