Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scrollto): Fix scroll to on rotated images #538

Merged
merged 2 commits into from
Jul 8, 2020
Merged

fix(scrollto): Fix scroll to on rotated images #538

merged 2 commits into from
Jul 8, 2020

Conversation

ConradJChan
Copy link
Contributor

No description provided.

@ConradJChan ConradJChan requested a review from a team as a code owner July 7, 2020 05:25
jstoffan
jstoffan reviewed Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. It seems like we shouldn't need rotate once/twice/thrice if we're calculating the rotation radians anyway, but if that's what we need to do, so be it.

src/region/__tests__/regionUtil-test.ts Outdated Show resolved Hide resolved
src/region/regionUtil.ts Show resolved Hide resolved
src/region/regionUtil.ts Outdated Show resolved Hide resolved
src/region/regionUtil.ts Outdated Show resolved Hide resolved
src/utils/scroll.ts Show resolved Hide resolved
src/region/transformUtils.ts Outdated Show resolved Hide resolved
src/region/transformUtils.ts Outdated Show resolved Hide resolved
src/region/transformUtils.ts Outdated Show resolved Hide resolved
src/region/regionUtil.ts Show resolved Hide resolved
src/region/regionUtil.ts Outdated Show resolved Hide resolved
jstoffan
jstoffan reviewed Jul 8, 2020
View reviewed changes
src/region/regionUtil.ts Outdated Show resolved Hide resolved
@ConradJChan ConradJChan force-pushed the scrollto-with-rotation branch 3 times, most recently from 378f14d to 322fbed Compare July 8, 2020 18:24
jstoffan
jstoffan reviewed Jul 8, 2020
View reviewed changes
src/utils/scroll.ts Outdated Show resolved Hide resolved
@ConradJChan ConradJChan force-pushed the scrollto-with-rotation branch from 322fbed to d37cd5d Compare July 8, 2020 20:18
jstoffan
jstoffan approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@ConradJChan ConradJChan merged commit 1253b0b into box:master Jul 8, 2020
@ConradJChan ConradJChan deleted the scrollto-with-rotation branch July 8, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConradJChan @jstoffan