chore(resin): Add resin tags to mentions list #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Jul 2, 2020
src/components/ItemList/ItemList.tsx
Outdated
| onSelect, | ||
| ...rest | ||
| }: Props<T>): JSX.Element => { | ||
| const ItemList = <T extends { id: string }>(props: Props<T>): JSX.Element => { |
There was a problem hiding this comment.
This file is meant to be a generic component, right? Should the resin tags live on a decorated version of ItemRow, instead?
ConradJChan
reviewed
Jul 6, 2020
There was a problem hiding this comment.
RE: #536 (comment), seems like moving the resin tags to ItemRow is still too specific toward at-mention
| let reduxSpy: jest.SpyInstance; | ||
|
|
||
| beforeEach(() => { | ||
| reduxSpy = jest.spyOn(ReactRedux, 'useSelector').mockImplementation(() => true); |
There was a problem hiding this comment.
Is this mockImplementation needed?
There was a problem hiding this comment.
Yeah it is needed since we use shallow above instead of mount.
|
ConradJChan
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.