perf(region): Refactor creator to modify rect directly during draw #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
force-pushed
the
perf-region-draw
branch
from
76614cd to
6350163
Compare
mxiao6
reviewed
May 19, 2020
jstoffan
force-pushed
the
perf-region-draw
branch
from
d25df48 to
093a74b
Compare
mxiao6
previously approved these changes
May 19, 2020
mxiao6
reviewed
May 19, 2020
|
|
||
| expect(instance.getPosition(100, 100)).toEqual([85, 85]); | ||
| simulateDrawStart(wrapper); | ||
| simulateDrawMove(50, 50); |
There was a problem hiding this comment.
Whoops, on second look it's just a dead test. I misread the diff even after your comment. Nice catch, will fix.
ConradJChan
previously approved these changes
May 19, 2020
| export function AutoScroller(props: Props, ref: React.Ref<Element>): JSX.Element { | ||
| const { as: Element = 'div', children, enabled, intensity = 0.2, onScroll = noop, size = 50, ...rest } = props; | ||
| export default function useAutoScroll(options: Options): void { | ||
| const { enabled, intensity = 0.2, onScroll = noop, reference, size = 50 } = options; |
There was a problem hiding this comment.
Could we destructure them out in the function arguments above?
There was a problem hiding this comment.
I can, but it breaks the function declaration onto multiple lines in an unpleasant way.
Comment on lines
+168
to
+172
| regionRect.setAttribute('height', `${height}`); | ||
| regionRect.setAttribute('width', `${width}`); | ||
| regionRect.setAttribute('x', `${x}`); | ||
| regionRect.setAttribute('y', `${y}`); | ||
| regionDirtyRef.current = false; |
mickr
previously approved these changes
May 19, 2020
mxiao6
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same thing as before, just 2-3x faster.
Todo