Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Remove autobind from base classes #44

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Chore: Remove autobind from base classes #44

merged 1 commit into from
Nov 22, 2017

Conversation

pramodsum
Copy link
Contributor

@pramodsum pramodsum commented Nov 21, 2017 •
edited
Loading

Removed from:

  • Annotation.js
  • AnnotationService.js
  • Annotator.js
  • AnnotationThread.js
  • AnnotationDialog.js

@boxcla
Copy link

boxcla commented Nov 21, 2017

Verified that @pramodsum has signed the CLA. Thanks for the pull request!

@pramodsum pramodsum changed the title Chore: Remove autobind from Annotations base classes Chore: Remove autobind from base classes Nov 21, 2017
@pramodsum pramodsum force-pushed the autobind branch 5 times, most recently from 445ab8c to 696cb86 Compare November 21, 2017 23:33
@pramodsum pramodsum merged commit 639f8d2 into box:master Nov 22, 2017
@pramodsum pramodsum deleted the autobind branch November 22, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinHoldstock JustinHoldstock JustinHoldstock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pramodsum @boxcla @JustinHoldstock