Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: date appears incorrectly for point annotations in IE11 #312

Merged
merged 3 commits into from
Dec 10, 2018
Merged

Fix: date appears incorrectly for point annotations in IE11 #312

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a931a9
Fix: date appears incorrectly for point annotations in IE11
DanDeMicco Dec 7, 2018
37562c7
Merge branch 'master' into date-point
DanDeMicco Dec 10, 2018
d0b899f
Merge branch 'master' into date-point
DanDeMicco Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AnnotationThread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ class AnnotationThread extends EventEmitter {
can_delete: true
},
createdBy: this.api.user,
createdAt: new Date().toLocaleString()
createdAt: new Date().toISOString()
});

this.state = STATES.inactive;
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/DrawingModeController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ class DrawingModeController extends AnnotationModeController {
canAnnotate: true,
canDelete: true,
createdBy: this.api.user,
createdAt: new Date().toLocaleString(),
createdAt: new Date().toISOString(),
isPending: true,
comments: []
});
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/PointModeController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class PointModeController extends AnnotationModeController {
canAnnotate: true,
canDelete: true,
createdBy: this.api.user,
createdAt: new Date().toLocaleString(),
createdAt: new Date().toISOString(),
isPending: true,
comments: []
});
Expand Down
2 changes: 1 addition & 1 deletion src/doc/DocAnnotator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ class DocAnnotator extends Annotator {
canAnnotate: true,
canDelete: true,
createdBy: this.api.user,
createdAt: new Date().toLocaleString()
createdAt: new Date().toISOString()
});
if (!thread) {
this.handleValidationError();
Expand Down