Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update test page for annotations 3.4 #301

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Chore: Update test page for annotations 3.4 #301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cb2a8e
Chore: Update test page for annotations 3.4
Nov 28, 2018
5c33f65
Chore: Use latest annotations version on NPM
Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<head>
<meta name="viewport" content="width=device-width">
<link rel="stylesheet" href='./styles.css' />
<link rel="stylesheet" href='https://cdn01.boxcdn.net/platform/preview/1.58.2/en-US/preview.css' />
<link rel="stylesheet" href='https://unpkg.com/box-annotations@3.3.0/lib/annotations.css' />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at https://unpkg.com/#/ and it seems to suggest we can fetch the latest version of the npm package by not specifying the version. Would it be beneficial to do that for both preview & annotations so this file doesn't need to get updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah! We can't do that for preview because it's not on NPM, but I'll do that for annotations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's sad, then we still need to do a preview update. Do we have control over the boxcdn to create a latest directory that points to the latest?

<link rel="stylesheet" href='https://cdn01.boxcdn.net/platform/preview/1.60.0/en-US/preview.css' />
<link rel="stylesheet" href='https://unpkg.com/box-annotations/lib/annotations.css' />
<script src='https://cdn01.boxcdn.net/polyfills/core-js/2.5.3/core.min.js'></script>
<script src='https://cdn01.boxcdn.net/platform/preview/1.58.2/en-US/preview.js'></script>
<script src='https://unpkg.com/box-annotations@3.3.0/lib/annotations.js'></script>
<script src='https://cdn01.boxcdn.net/platform/preview/1.60.0/en-US/preview.js'></script>
<script src='https://unpkg.com/box-annotations/lib/annotations.js'></script>
</head>

<body>
Expand Down