Merging Annotation header changes #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update: Adding headerElement to annotator options * Update: headerElement fallback to container when using preview header * Chore: hide the annotation button on destroy * Chore: default to header container * Chore: addressing comments * Chore: Only hideButton if modeButton exists
|
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
pramodsum
commented
Oct 16, 2018
src/Annotator.js
Outdated
| // If using box content preview header and no external header element was specified, | ||
| // fallback to the container element | ||
| if (this.options.header !== 'none' && !this.headerElement) { | ||
| this.headerElement = this.container.querySelector(SELECTOR_BOX_PREVIEW_HEADER_CONTAINER); |
There was a problem hiding this comment.
@ConradJChan It seems like this class is never loaded onto the preview header? The default preview header seems to use bp-header
JustinHoldstock
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ConradJChan let me know if I messed up any merge conflicts anywhere!