Fix: Replace {1} with user name on drawing save #179
Conversation
|
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
| assignDrawingLabel(savedAnnotation) { | ||
| if (!savedAnnotation || !this.drawingDialogEl) { | ||
| assignDrawingLabel(annotation) { | ||
| if (!annotation || !this.drawingDialogEl || annotation.user.id === '0') { |
There was a problem hiding this comment.
We need to ensure that the user id is not '0' so that we know the API has returned a valid user name and successfully saved the new annotation
There was a problem hiding this comment.
Are we sure that the annotation will have a user? user.id could throw an error otherwise.
There was a problem hiding this comment.
The temporary annotation contains a blank user w/ an id of 0. Once the API successfully saves an annotation, it returns a user with a valid id
There was a problem hiding this comment.
| assignDrawingLabel(savedAnnotation) { | ||
| if (!savedAnnotation || !this.drawingDialogEl) { | ||
| assignDrawingLabel(annotation) { | ||
| if (!annotation || !this.drawingDialogEl || annotation.user.id === '0') { |
There was a problem hiding this comment.
Are we sure that the annotation will have a user? user.id could throw an error otherwise.
| @@ -145,7 +146,7 @@ class DocDrawingDialog extends AnnotationDialog { | |||
|
|
|||
| const firstAnnotation = util.getFirstAnnotation(annotations); | |||
| if (firstAnnotation) { | |||
| this.assignDrawingLabel(firstAnnotation); | |||
| this.addAnnotation(firstAnnotation); | |||
There was a problem hiding this comment.
Does addAnnotation get called when creating an annotation OR rendering an existing one?
My understanding of this code is:
We're setting up a dialog, so if there's an annotation already in that dialog, add it to the dialog. Draw dialogs can only have one annotation (no comments), so we're not really adding an annotation here, but loading the previously saved annotation into this dialog.
There was a problem hiding this comment.
Both. addAnnotation just adds the element to the dialog so it occurs either when the dialog is initially being set up or when a new annotation is saved to the thread (which only occurs once for drawing annotations)
No description provided.