Chore: Group CSS constants in a more readable manner #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
pramodsum
changed the title
| @@ -12,6 +12,8 @@ import { | |||
| SELECTOR_ANNOTATION_DIALOG | |||
| } from '../../constants'; | |||
|
|
|||
| const SELECTOR_ANNOTATED_ELEMENT = '.annotated-element'; | |||
There was a problem hiding this comment.
Can you roll .annotated-element into constants. It's been copy-pasted in quite a few places
src/doc/docUtil.js
Outdated
| @@ -61,8 +43,10 @@ export function isPresentation(annotatedElement) { | |||
| * @return {boolean} Whether or not a dialog is active | |||
| */ | |||
| export function hasActiveDialog(annotatedEl) { | |||
| const commentsDialogEl = annotatedEl.querySelector(`.${CLASS_ANNOTATION_DIALOG}:not(.bp-is-hidden)`); | |||
| const highlightDialogEl = annotatedEl.querySelector(`.${CLASS_ANNOTATION_HIGHLIGHT_DIALOG}:not(.bp-is-hidden)`); | |||
| const commentsDialogEl = annotatedEl.querySelector(`.${constants.CLASS_ANNOTATION_DIALOG}:not(.bp-is-hidden)`); | |||
There was a problem hiding this comment.
Can you put bp-is-hidden into constants?
jeremypress
approved these changes
Mar 30, 2018
|
Initially I think we did that for classes where we're not really using many constants. I do plan on going through and just doing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.