Fix: Don't save empty drawing threads #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pramodsum
commented
Mar 14, 2018
•
pramodsum
commented
- Fixes issue where users couldn't select drawings after pressing the "Done" button
- Drawing handlers require a blank temporary thread in order to actually start/stop drawing. This thread is not yet saved into the API and will not have valid location information until the user actually begins drawing. This prevents the controller from saving that empty thread until it contains valid location information.
- Validates min/max boundary coordinates for annotation threads
- Drawing handlers require a blank temporary thread in order to actually start/stop drawing. This thread is not yet saved into the API and will not have valid location information until the user actually begins drawing. This prevents the controller from saving that empty thread until it contains valid location information.
|
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
pramodsum
changed the title
pramodsum
changed the title
src/util.js
Outdated
| export function hasValidBoundaryCoordinates(thread) { | ||
| return !!( | ||
| isHighlightAnnotation(thread.type) || | ||
| (thread.minX && |
There was a problem hiding this comment.
AFAIK NaN is neither true nor false (NaN == true is false, and NaN == false is false). you may not need to do your Math.isNaN() checks here.
jeremypress
reviewed
Mar 15, 2018
| @@ -134,7 +143,10 @@ class DrawingModeController extends AnnotationModeController { | |||
| }); | |||
|
|
|||
| this.pushElementHandler(this.postButtonEl, 'click', () => { | |||
| this.saveThread(this.currentThread); | |||
| if (this.hasPendingDrawing) { | |||
There was a problem hiding this comment.
use thread status instead of this extra boolean
JustinHoldstock
approved these changes
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.