fix(log): Fix resin isCurrentFileVersion is always true

box · Jul 22, 2020 · f932500 · f932500
1 parent 028af26
commit f932500
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/common/BaseAnnotator.ts b/src/common/BaseAnnotator.ts
@@ -14,6 +14,7 @@ export type FileOptions = {
         annotations?: {
             activeId?: string;
         };
+        currentFileVersionId?: string;
         fileVersionId?: string;
     };
 };
@@ -53,8 +54,9 @@ export default class BaseAnnotator extends EventEmitter {
         super();
 
         const fileOptionsValue = fileOptions?.[file.id];
+        const currentFileVersionId = fileOptionsValue?.currentFileVersionId;
         const fileOptionsVersionId = fileOptionsValue?.fileVersionId;
-        const fileVersionId = file.file_version.id;
+        const fileVersionId = file.file_version.id; // This is always the currently-previewed version id, not current version id
 
         const initialState = {
             annotations: {
@@ -63,7 +65,7 @@ export default class BaseAnnotator extends EventEmitter {
             options: {
                 fileId: file.id,
                 fileVersionId: fileOptionsVersionId ?? fileVersionId,
-                isCurrentFileVersion: !fileOptionsVersionId || fileOptionsVersionId === fileVersionId,
+                isCurrentFileVersion: !fileOptionsVersionId || fileOptionsVersionId === currentFileVersionId,
                 permissions: file.permissions,
             },
         };

diff --git a/src/common/__tests__/BaseAnnotator-test.ts b/src/common/__tests__/BaseAnnotator-test.ts
@@ -109,19 +109,20 @@ describe('BaseAnnotator', () => {
         });
 
         test.each`
-            fileOptionsVersionId | fileVersionId | isCurrentFileVersion
-            ${'0'}               | ${'0'}        | ${true}
-            ${undefined}         | ${'0'}        | ${true}
-            ${'1'}               | ${'0'}        | ${false}
+            fileOptionsVersionId | currentFileVersionId | isCurrentFileVersion
+            ${'0'}               | ${'0'}               | ${true}
+            ${undefined}         | ${'0'}               | ${true}
+            ${'1'}               | ${'0'}               | ${false}
         `(
             'should set isCurrentFileVersion to $isCurrentFileVersion',
-            ({ fileOptionsVersionId, fileVersionId, isCurrentFileVersion }) => {
+            ({ currentFileVersionId, fileOptionsVersionId, isCurrentFileVersion }) => {
                 const file = {
                     ...defaults.file,
-                    file_version: { id: fileVersionId },
+                    file_version: { id: fileOptionsVersionId },
                 };
                 const fileOptions = {
                     '12345': {
+                        currentFileVersionId,
                         fileVersionId: fileOptionsVersionId,
                     },
                 };