Fix: Validate pendingThreadID when calling onSelectionChange() (#39)

box · Nov 16, 2017 · 10c1c98 · 10c1c98
1 parent 1f88d55
commit 10c1c98
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/doc/DocAnnotator.js b/src/doc/DocAnnotator.js
@@ -576,7 +576,7 @@ class DocAnnotator extends Annotator {
         // Do nothing if in a text area or mobile dialog or mobile create dialog is already open
         const isHidden = this.mobileDialogEl && this.mobileDialogEl.classList.contains(CLASS_HIDDEN);
         const pointController = this.modeControllers[TYPES.point];
-        const isCreatingPoint = pointController && pointController.pendingThreadID !== null;
+        const isCreatingPoint = !!(pointController && pointController.pendingThreadID);
         if (isCreatingPoint || !isHidden || document.activeElement.nodeName.toLowerCase() === 'textarea') {
             return;
         }

diff --git a/src/doc/__tests__/DocAnnotator-test.js b/src/doc/__tests__/DocAnnotator-test.js
@@ -1107,7 +1107,7 @@ describe('doc/DocAnnotator', () => {
 
             annotator.highlighter = { removeAllHighlights: sandbox.stub() };
             annotator.modeControllers = {
-                'point': { pendingThreadID: null }
+                'point': {}
             };
 
             stubs.getSelStub = sandbox.stub(window, 'getSelection');