Skip to content
This repository has been archived by the owner on Sep 6, 2020. It is now read-only.

Fix the composer autoloader location for cgr #164

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from

Conversation

mikeSimonson
Copy link

@mikeSimonson mikeSimonson commented Apr 4, 2017

There is a tool called cgr (for composer global require) that
install every tool that needs to be globaly available in their own
custom folder. It does so that each tool dependecy don't infuences
other tools dependencies.

This means that the logic that was previously used by the autoloader
location code for box is broken. For some reason the code used to look
for the last autoloader in the folder structure ( the one closest to
the root folder ). I have no idea why it was doing so.

For cgr to work it needs to be the first one found that needs to be
used. I have changed the logic accordingly in this PR as well as
removed some dead code (an option that was never used).

Any comment ?

There is a tool called cgr (for composer global require) that
install every tool that needs to be globaly available in their own
custom folder. It does so that each tool dependecy don't infuences
other tools dependencies.

This means that the logic that was previously used by the autoloader
location code for box is broken. For some reason the code used to look
for the last autoloader in the folder structure ( the one closest to
the root folder ). I have no idea why it was doing so.

For cgr to work it needs to be the first one found that needs to be
used. I have changed the logic accordingly in this PR as well as
removed some dead code (an option that was never used).
@theofidry
Copy link
Member

Ping @kherge: this actually makes much more sense as you're likely to want the first vendor (which 99% will be your project one) and not the most global one.

@theofidry
Copy link
Member

@mikeSimonson see box-project/box#3

@mikeSimonson
Copy link
Author

@theofidry Thanks. Is humbug fork the main repo now ?

@theofidry
Copy link
Member

theofidry commented Nov 16, 2017

@mikeSimonson yeah. Well at least I'm working on it as I couldn't get hold on Keven Herrera to access to this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants