[WIP] Update Windows compatibility #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for looking into this, IIRC @c33s could be interested in it as well :) Maybe a utility function could be added for normalizing the paths in the tests rather than having to deal with Note: I'll enabled AppVeyor on the repo as soon as you think this PR is good |
asgrim
reviewed
Sep 21, 2018
| @@ -1126,7 +1126,7 @@ public function test_the_blacklist_input_may_refer_to_non_existent_paths(): void | |||
| { | |||
| $this->setConfig([ | |||
| 'blacklist' => [ | |||
| '/nowhere', | |||
| ($this->isWindows() ? 'C:' : '') . '/nowhere', | |||
|
do we need |
|
I'll be closing this. If one is ready to take up the task once again now GitHub actions supports Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
This PR adds a Appveyor configuration to run CI on Windows machines, and also tries to address some windows compatibility.
There are currrently a lot of failures related to path names (See an example of some of the build failures: https://ci.appveyor.com/project/pierredup/box/build/job/yv2tts08s4ilxft4)) which needs to be updated first to get as much tests as possible to pass, so that the actual Windows issues can be clearly identified.
Appveyor will need to be enabled for this repository, so that all future builds can run against windows to ensure compatibility doesn't break.