Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to point to "types" #341

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

DarkPurple141
Copy link
Contributor

Also note that if your main declaration file is named index.d.ts and lives at the root of the package (next to index.js) you do not need to mark the "types" property, though it is advisable to do so.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 659

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.838%

Totals Coverage Status
Change from base Build 652: 0.0%
Covered Lines: 506
Relevant Lines: 523

💛 - Coveralls

@DarkPurple141 DarkPurple141 changed the title Update package.json to to point to "types" Update package.json to point to "types" Jul 30, 2019
@lancedikson
Copy link
Collaborator

Great, thanks! Probably forgot to put it right away when described the types.

@lancedikson lancedikson merged commit 152ac45 into bowser-js:master Jul 31, 2019
@DarkPurple141
Copy link
Contributor Author

DarkPurple141 commented Jul 31, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants