-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main should be a place for libraries, not sources #46
Conversation
The main should contain files that can be used as library, not as sources. They can also contain the sources in forms of `less`, `sass`, or even `d.ts` files, so that the consuming party can choose based on filetype what to use and include in the project. Arguably even `.min.js` can also be added as it's the 'definitive' version of a 'compiled' library. See also twbs/bootstrap compliance to the spec issues: twbs/bootstrap#16663
+1, please accept this pull request, I don't feel like compiling all the external libraries myself every time. |
Thanks for this contribution. We have resolve that main is for entry-point source files, not for distribution files. To resolve the Bootstrap issue, I've proposed a new We'll have to pass on the PR, but your efforts are appreciated. |
I think That said |
Added that the 'main' is not **only** for the compiled version, but also for the versions that can be used as libraries in case of `less`, `sass`, and maybe even `ts` files.
@@ -47,7 +47,7 @@ The package's semantic version number. | |||
*Recommended* | |||
Type: `String` or `Array` of `String` | |||
|
|||
The entry-point files necessary to use your package. Only one file per filetype. | |||
The entry-point files necessary to use your package. Only one file per filetype. The files that are offered should be representing your package as library. This means that the files can be used without compiling for use by the consuming party. This is not limited to **only** the 'compiled' version. In case of `.less`, `.scss` or `(d).ts` etc. they can be used as library aswell when used in the consuming party source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"as well"
I don't think saying "as a library" offers any clarification. If anything, it makes me think of stuff like a library of Less/Sass mixins that the user would then import and use in their own Less/Sass file, which is in the opposite direction of what you're actually intending to propose. |
The main should contain files that can be used as library, not as sources. They can also contain the sources in forms of
less
,sass
, or evend.ts
files, so that the consuming party can choose based on filetype what to use and include in the project. Arguably even.min.js
can also be added as it's the 'definitive' version of a 'compiled' library.See also twbs/bootstrap compliance to the spec issues: twbs/bootstrap#16663