List of Datasets argument to open_boutdataset() #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as reading Datasets from disk, allow list of Datasets to be passed as the argument to open_boutdataset(). Intended for speeding up unit tests.
Avoids complicating the Dataset-argument path in open_boutdataset.
Now many tests no longer have to create files on disk, the tmpdir_factory is not necessary for those tests. Remove references to it, hoping this speeds up the tests a bit.
johnomotani
added
the
testing
|
Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-04 00:35:52 UTC |
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 71.61% 71.74% +0.13%
==========================================
Files 14 14
Lines 1705 1727 +22
Branches 363 371 +8
==========================================
+ Hits 1221 1239 +18
- Misses 380 383 +3
- Partials 104 105 +1
Continue to review full report at Codecov.
|
This was referenced Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
open_boutdataset()to optionally take a list of existingDatasets instead of a filename-glob. Useful for unit tests which no longer have to create files on disk and then read them. Speeds up the unit tests, which is useful so we can add more tests in other PRs without making Travis time out. A few unit tests do still read and write files, so this functionality is still tested.