Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement server-side storage / accounts #13

Closed
bourgeoisor opened this issue Oct 11, 2021 · 8 comments
Closed

Implement server-side storage / accounts #13

bourgeoisor opened this issue Oct 11, 2021 · 8 comments
Labels
priority: p1 Need to be worked on soon type: feature New feature or request

Comments

@bourgeoisor
Copy link
Owner

Currently, XIV ToDo utilizes localStorage for storing character data. This works, but means that there is no cross-device capabilities (e.g. syncing the same character progress on mobile and on a desktop browser).

A server-side service coupled with storage could be used to enable this (complete with e.g. Discord oAuth).

@bourgeoisor bourgeoisor added type: feature New feature or request priority: p1 Need to be worked on soon labels Oct 11, 2021
@Coggi
Copy link

Coggi commented Dec 8, 2021

Hi,

is this being worked on?
It would be very useful for people like me who plays from different PCs :/

Thank you!

@Kunamatata
Copy link

@bourgeoisor happy to help you with this task if you have any leads or any backend already.

@bourgeoisor
Copy link
Owner Author

Between Endwalker and work, I haven't had much opportunity to work on this, but it's one of my goal for early 2022!

@Kunamatata
Copy link

Enjoy endwalker <3 There is no rush!

@bourgeoisor
Copy link
Owner Author

This is now implemented in #19 🎉

Announcement Tweet: https://twitter.com/XIVToDo/status/1503906490788237312

@salixh5
Copy link

salixh5 commented Nov 1, 2023

Unfortunately this change made it impossible to use the site to the full extent for users without a Discord account. In some countries, Discord is completely blocked, and even for users outside of these countries, they might not agree with the Discord ToS or have been banned from using Discord.

Is there a possibility you would be open for any other auth methods?

Edit: Case in point, I just tried to signup for a new Discord account to use the site. I haven't used Discord at all before, I used their official client for this, and after signup I'm immediately forced to verify with a phone number for reasons only known to them. Cannot use the account now, unless I give my phone number to yet another company. This is not acceptable.

@bourgeoisor
Copy link
Owner Author

Hi @jayna37! I understand your feedback and empathize, but as a sole developer doing this in my free time (and with limited funds -- practically nil) I wouldn't want to put it on me to securely store user credentials. With oauth, that is out of my hands and I don't need to worry about data leaks coming from my side, since XIV ToDo doesn't store or handle any user credentials.

I could consider implementing oauth with other Discord alternatives like Google or Twitter (X), but if I understand your feedback correctly this wouldn't help you, since you'd have to give your phone number (or other information) to those companies just as well.

Re-implementing an "offline" mode (no accounts, data stored locally only) is also very unrealistic for me, given the limited amount of time I can spare on this project.

Do you have any other suggestions?

@salixh5
Copy link

salixh5 commented Nov 2, 2023

Thank you for your extensive reply, that means a lot. For me personally indeed Google and X are not services I use or would like to use. But I could imagine that for some users that would already be an improvement that they would enjoy.

Definitely understand that having to store auth credentials yourself is not on the table. Here are some OAuth2 / OpenID Connect providers that I think you could also consider:

  • SimpleLogin - a subsidiary of Proton AG (Proton Mail etc.)
  • Twitch - also gaming-related, belongs to Amazon but doesn’t generally require personal information just to maintain the account
  • GitHub and/or GitLab - there‘s some overlap between avid gamers and developers, so these could still be a good fit.

I would also happy to develop, test and make a PR for another service if you are in support of adding it in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Need to be worked on soon type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants