Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] ViewPostPage dropdowns have been added #394

Merged
merged 3 commits into from
Dec 4, 2022
Merged

[Mobile] ViewPostPage dropdowns have been added #394

merged 3 commits into from
Dec 4, 2022

Conversation

bbenginbestas
Copy link
Contributor

Description:

  • Dropdowns have been added to Posts and Comments. For posts, it changes depending on the active user.

Tasks Done:

  • Dropdown icon has been added at the top-right of post/comment.
  • The dropdown now includes 'Edit' and 'Delete' if it was created by the active user.
  • The dropdown now includes 'Report' if it was not created by the active user.

Reviewer:
@palahb

Notes:

  • For comments, dropdowns will change according to the author of comments with the API.

Issue:

@bbenginbestas bbenginbestas self-assigned this Dec 4, 2022
@bbenginbestas bbenginbestas added Prio: Medium Importance of Issue: Medium Type: Enhancement New features via code and/or design. Status: Need Review Issue work is done, waiting to be reviewed Team: Mobile Mobile based work - for mobile team labels Dec 4, 2022
@bbenginbestas bbenginbestas linked an issue Dec 4, 2022 that may be closed by this pull request
[Mobile] Adding dropdown for 'ViewPost' page #387
Closed
3 tasks
palahb
palahb approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@palahb palahb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropdown seems seamlessly working. Thank you Bengin!

@palahb palahb merged commit f18b60d into master Dec 4, 2022
@bbenginbestas bbenginbestas added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palahb palahb palahb approved these changes

Assignees

@bbenginbestas bbenginbestas

Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Team: Mobile Mobile based work - for mobile team Type: Enhancement New features via code and/or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mobile] Adding dropdown for 'ViewPost' page
2 participants
@bbenginbestas @palahb