Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Response formatting #381

Merged
merged 5 commits into from
Dec 4, 2022
Merged

[Backend] Response formatting #381

merged 5 commits into from
Dec 4, 2022

Conversation

mehmetemreakbulut
Copy link
Contributor

@mehmetemreakbulut mehmetemreakbulut commented Dec 4, 2022 •
edited
Loading

Description:
In last MR search query was not implemented yet. I have added search functionality to the get all posts endpoint.
Also guest user related problems fixed.

Tasks Done:

  • Search Query
  • Guest user auth fixed

Reviewer: @oguzhandemirelx
Notes:
Search text will be given on query with q parameter.
Issue:

Task Deadline: 04.12.2022 18:00
Review Deadline: 04.12.2022 23:59

@mehmetemreakbulut mehmetemreakbulut added Prio: High Importance of Issue: High Type: Enhancement New features via code and/or design. Status: In Progress Issue is worked on, currently Team: Backend Backend based work - for backend team labels Dec 4, 2022
@mehmetemreakbulut mehmetemreakbulut self-assigned this Dec 4, 2022
oguzhandemirelx
oguzhandemirelx reviewed Dec 4, 2022
View reviewed changes
Copy link
Contributor

@oguzhandemirelx oguzhandemirelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely implemented. Fixes are done and work properly. Thanks for your effort.

@oguzhandemirelx oguzhandemirelx merged commit ba356ca into master Dec 4, 2022
@palahb palahb added Status: Need Review Issue work is done, waiting to be reviewed Status: Accepted Issue is reviewed, accepted and removed Status: In Progress Issue is worked on, currently Status: Need Review Issue work is done, waiting to be reviewed labels Dec 6, 2022
@mehmetemreakbulut mehmetemreakbulut changed the title Backend/feature/response formatting #366 [Backend] Response formatting Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguzhandemirelx oguzhandemirelx oguzhandemirelx left review comments

Assignees

@mehmetemreakbulut mehmetemreakbulut

Labels
Prio: High Importance of Issue: High Status: Accepted Issue is reviewed, accepted Team: Backend Backend based work - for backend team Type: Enhancement New features via code and/or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehmetemreakbulut @oguzhandemirelx @palahb