Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Getting all posts of a user #333

Merged
merged 2 commits into from
Nov 27, 2022
Merged

[Backend] Getting all posts of a user #333

merged 2 commits into from
Nov 27, 2022

Conversation

irfanbozkurt
Copy link
Member

@irfanbozkurt irfanbozkurt commented Nov 27, 2022 •
edited
Loading

Description:

We have two endpoints to fetch posts: get by id and get all with pagination.
However, users might need to fetch posts created by a specific user.

Todo's:

  • Implement get_posts_of method and expose the API
  • Update wiki accordingly
  • Handle pagination

Reviewer: @mehmetemreakbulut

Task Deadline: 28.11.2020 00.00

@irfanbozkurt irfanbozkurt added Type: Enhancement New features via code and/or design. Team: Backend Backend based work - for backend team labels Nov 27, 2022
@irfanbozkurt irfanbozkurt self-assigned this Nov 27, 2022
@irfanbozkurt
Copy link
Member Author

See the wiki for explanation of the endpoint.

@irfanbozkurt
Update views.py
9a262cd 
update page size
mehmetemreakbulut
mehmetemreakbulut approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@mehmetemreakbulut mehmetemreakbulut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.
But pagination not fully compatible with convention. Need fix later!

@mehmetemreakbulut
Copy link
Contributor

  • See comment on review
  • Looks okey. I'll merge but you need to consider the comment for other pull requests.
  • Thanks for your all effort.

@mehmetemreakbulut mehmetemreakbulut merged commit 3ee9c3d into master Nov 27, 2022
@palahb palahb deleted the backend/feature/posts_of_user-#332 branch December 6, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehmetemreakbulut mehmetemreakbulut mehmetemreakbulut approved these changes

Assignees

@irfanbozkurt irfanbozkurt

Labels
Team: Backend Backend based work - for backend team Type: Enhancement New features via code and/or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irfanbozkurt @mehmetemreakbulut