Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Drawer head in the Home page is updated #280

Merged
merged 1 commit into from
Oct 31, 2022
Merged

[Mobile] Drawer head in the Home page is updated #280

merged 1 commit into from
Oct 31, 2022

Conversation

palahb
Copy link
Contributor

@palahb palahb commented Oct 31, 2022

Description:
To create a user specific home page, user should be able to see his/her name or username or email. For our case, since just the email is available for an user, I needed to correct drawer head in a way that it shows the email of the user.

Tasks Done:

  • Instead of a dummy name like 'John', user can now see his/her email in drawer head in the home page.
  • Height of this header has been increased to prevent overflows.

Reviewer: @enginoguzhansenol

Issue:

@palahb palahb added Type: Bug Something isn't working Prio: Low Importance of Issue: Low Status: Need Review Issue work is done, waiting to be reviewed Team: Mobile Mobile based work - for mobile team labels Oct 31, 2022
@palahb palahb self-assigned this Oct 31, 2022
@palahb palahb linked an issue Oct 31, 2022 that may be closed by this pull request
[Mobile] Display user email in home page's drawer head #279
Closed
2 tasks
@enginoguzhansenol enginoguzhansenol merged commit a0d70f9 into master Oct 31, 2022
@enginoguzhansenol
Copy link
Contributor

It seems that the bug is fixed. The email of te user appears in the drawer. Thank you for your effort. Merged the pull request.

@palahb palahb added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Oct 31, 2022
@palahb palahb deleted the mobile/bug-fix/show-user-email-in-drawer-#279 branch December 6, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enginoguzhansenol enginoguzhansenol Awaiting requested review from enginoguzhansenol

Assignees

@palahb palahb

Labels
Prio: Low Importance of Issue: Low Status: Accepted Issue is reviewed, accepted Team: Mobile Mobile based work - for mobile team Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mobile] Display user email in home page's drawer head
2 participants
@palahb @enginoguzhansenol