Delete sandbox and runtime, and clean up directory structure #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheEvilSkeleton
force-pushed
the
cleanup
branch
from
af78b87 to
d28f223
Compare
TheEvilSkeleton
force-pushed
the
cleanup
branch
from
d28f223 to
5893b17
Compare
underlinejakez
suggested changes
Dec 20, 2024
underlinejakez
suggested changes
Dec 20, 2024
TheEvilSkeleton
force-pushed
the
cleanup
branch
3 times, most recently
from
d67cd11 to
e97f477
Compare
TheEvilSkeleton
force-pushed
the
cleanup
branch
from
e97f477 to
58a4945
Compare
TheEvilSkeleton
changed the title
TheEvilSkeleton
force-pushed
the
cleanup
branch
from
58a4945 to
41712b4
Compare
This cleans up a considerable chunk of the codebase by removing the dedicated sandbox. As it stands, we only support sandboxed formats, so we might as well delete the unmaintained one. This also removes a lot of unnecessary checks in regards to packaging. Since the Flatpak includes everything we need, we might as well just not have these checks anymore. Some of the checks early return.
This also moves `flatpak-pip-generator.py` to `build-aux`.
TheEvilSkeleton
force-pushed
the
cleanup
branch
from
41712b4 to
da4f5ab
Compare
underlinejakez
approved these changes
Dec 22, 2024
mirkobrombin
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This cleans up a considerable chunk of the codebase by removing the dedicated sandbox. As it stands, we only support sandboxed formats, so we might as well delete the unmaintained one.
This also removes a lot of unnecessary checks in regards to packaging. Since the Flatpak includes everything we need, we might as well just not have these checks anymore.
Some of the checks early return.
Type of change