Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pre-commit #3592

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Conversation

TheEvilSkeleton
Copy link
Member

Description

This uses pre-commit along with other utilities like MyPy, ruff, and autoflake

@mirkobrombin is this something we want to do?

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Pylint result on modfied files:
************* Module bottles.backend.globals
bottles/backend/globals.py:25:0: R0903: Too few public methods (1/2) (too-few-public-methods)
bottles/backend/globals.py:65:0: R0903: Too few public methods (0/2) (too-few-public-methods)
bottles/backend/globals.py:79:0: C0103: Constant name "vkbasalt_available" doesn't conform to UPPER_CASE naming style (invalid-name)
bottles/backend/globals.py:83:0: C0103: Constant name "base_version" doesn't conform to UPPER_CASE naming style (invalid-name)
bottles/backend/globals.py:22:0: W0611: Unused yaml imported from bottles.backend.utils (unused-import)
************* Module bottles.backend.models.config
bottles/backend/models/config.py:62:5: W0511: share_host_ro: bool = True  # TODO: implement, requires the Bottles runtime (next) for a minimal sandbox (fixme)
bottles/backend/models/config.py:63:5: W0511: share_gpu: bool = True  # TODO: implement (fixme)
bottles/backend/models/config.py:64:5: W0511: share_paths_ro: List[str] = field(default_factory=lambda: [])  # TODO: implement (fixme)
bottles/backend/models/config.py:65:5: W0511: share_paths_rw: List[str] = field(default_factory=lambda: [])  # TODO: implement (fixme)
bottles/backend/models/config.py:235:9: W0511: TODO: remove after some time (fixme)
bottles/backend/models/config.py:118:4: C0103: Attribute name "Name" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:119:4: C0103: Attribute name "Arch" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:120:4: C0103: Attribute name "Windows" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:121:4: C0103: Attribute name "Runner" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:122:4: C0103: Attribute name "WorkingDir" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:123:4: C0103: Attribute name "DXVK" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:124:4: C0103: Attribute name "NVAPI" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:125:4: C0103: Attribute name "VKD3D" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:126:4: C0103: Attribute name "LatencyFleX" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:127:4: C0103: Attribute name "Path" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:128:4: C0103: Attribute name "Custom_Path" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:129:4: C0103: Attribute name "Environment" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:130:4: C0103: Attribute name "Creation_Date" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:131:4: C0103: Attribute name "Update_Date" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:132:4: C0103: Attribute name "Versioning" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:133:4: C0103: Attribute name "Versioning_Exclusion_Patterns" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:134:4: C0103: Attribute name "State" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:135:4: C0103: Attribute name "Parameters" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:136:4: C0103: Attribute name "Sandbox" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:137:4: C0103: Attribute name "Environment_Variables" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:138:4: C0103: Attribute name "Installed_Dependencies" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:139:4: C0103: Attribute name "DLL_Overrides" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:140:4: C0103: Attribute name "External_Programs" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:141:4: C0103: Attribute name "Uninstallers" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:144:4: C0103: Attribute name "Language" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:147:4: C0103: Attribute name "CompatData" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:149:4: C0103: Attribute name "RunnerPath" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/models/config.py:161:50: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/models/config.py:161:50: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/models/config.py:185:54: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/models/config.py:185:54: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module bottles.backend.utils.snake
bottles/backend/utils/snake.py:49:12: W0702: No exception type(s) specified (bare-except)
bottles/backend/utils/snake.py:86:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/backend/utils/snake.py:100:0: C0103: Constant name "result" doesn't conform to UPPER_CASE naming style (invalid-name)
bottles/backend/utils/snake.py:104:4: W0603: Using the global statement (global-statement)
bottles/backend/utils/snake.py:112:4: C0103: Constant name "logo" doesn't conform to UPPER_CASE naming style (invalid-name)
bottles/backend/utils/snake.py:140:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/backend/utils/snake.py:142:8: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
************* Module bottles.backend.utils.proc
bottles/backend/utils/proc.py:46:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
************* Module bottles.backend.utils.lnk
bottles/backend/utils/lnk.py:34:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/utils/lnk.py:42:16: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/utils/lnk.py:54:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/utils/lnk.py:23:0: R0903: Too few public methods (1/2) (too-few-public-methods)
************* Module bottles.backend.utils.file
bottles/backend/utils/file.py:120:8: C0103: Variable name "FS_IOC_GETFLAGS" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/utils/file.py:121:8: C0103: Variable name "FS_IOC_SETFLAGS" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/utils/file.py:122:8: C0103: Variable name "FS_CASEFOLD_FL" doesn't conform to snake_case naming style (invalid-name)
************* Module bottles.backend.utils.wine
bottles/backend/utils/wine.py:4:0: R0903: Too few public methods (1/2) (too-few-public-methods)
************* Module bottles.backend.utils.vdf
bottles/backend/utils/vdf.py:35:0: C0103: Class name "string_type" doesn't conform to PascalCase naming style (invalid-name)
bottles/backend/utils/vdf.py:36:0: C0103: Class name "int_type" doesn't conform to PascalCase naming style (invalid-name)
bottles/backend/utils/vdf.py:153:20: W0707: Consider explicitly re-raising using 'except StopIteration as exc' and 'raise SyntaxError('vdf.parse: unexpected EOF (open key quote?)', (getattr(fp, 'name', '<%s>' % fp.__class__.__name__), lineno, 0, line)) from exc' (raise-missing-from)
bottles/backend/utils/vdf.py:205:24: W0707: Consider explicitly re-raising using 'except StopIteration as exc' and 'raise SyntaxError('vdf.parse: unexpected EOF (open quote for value?)', (getattr(fp, 'name', '<%s>' % fp.__class__.__name__), lineno, 0, line)) from exc' (raise-missing-from)
bottles/backend/utils/vdf.py:240:13: E0602: Undefined variable 'strIO' (undefined-variable)
bottles/backend/utils/vdf.py:298:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from)
bottles/backend/utils/vdf.py:309:0: C0103: Class name "BASE_INT" doesn't conform to PascalCase naming style (invalid-name)
bottles/backend/utils/vdf.py:311:15: E1307: Argument 'bottles.backend.utils.vdf.BASE_INT' does not match format type 'd' (bad-string-format-type)
bottles/backend/utils/vdf.py:314:0: C0103: Class name "UINT_64" doesn't conform to PascalCase naming style (invalid-name)
bottles/backend/utils/vdf.py:318:0: C0103: Class name "INT_64" doesn't conform to PascalCase naming style (invalid-name)
bottles/backend/utils/vdf.py:424:12: W0702: No exception type(s) specified (bare-except)
bottles/backend/utils/vdf.py:430:4: C0103: Variable name "CURRENT_BIN_END" doesn't conform to snake_case naming style (invalid-name)
bottles/backend/utils/vdf.py:523:12: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from)
bottles/backend/utils/vdf.py:533:12: W0702: No exception type(s) specified (bare-except)
************* Module bottles.backend.utils.steam
bottles/backend/utils/steam.py:21:0: W0404: Reimport 'TextIO' (imported line 20) (reimported)
bottles/backend/utils/steam.py:61:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/utils/steam.py:61:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/utils/steam.py:80:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/utils/steam.py:80:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
************* Module bottles.backend.utils.json
bottles/backend/utils/json.py:4:0: W0404: Reimport 'json' (imported line 3) (reimported)
************* Module bottles.backend.utils.display
bottles/backend/utils/display.py:20:16: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/utils/display.py:40:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
************* Module bottles.backend.managers.installer
bottles/backend/managers/installer.py:99:20: I1101: Module 'pycurl' has no 'Curl' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/installer.py:101:38: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/managers/installer.py:251:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/managers/installer.py:230:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/backend/managers/installer.py:355:4: R0913: Too many arguments (6/5) (too-many-arguments)
bottles/backend/managers/installer.py:355:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
************* Module bottles.backend.managers.component
bottles/backend/managers/component.py:89:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:128:4: R0913: Too many arguments (6/5) (too-many-arguments)
bottles/backend/managers/component.py:128:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
bottles/backend/managers/component.py:147:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:158:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:165:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:170:16: I1101: Module 'pycurl' has no 'Curl' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/component.py:180:19: I1101: Module 'pycurl' has no 'error' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)
bottles/backend/managers/component.py:188:16: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:202:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:216:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:222:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:267:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:288:16: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:273:18: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/managers/component.py:245:16: W0613: Unused argument 'name' (unused-argument)
bottles/backend/managers/component.py:328:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:339:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:347:8: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:358:8: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/component.py:468:8: W0105: String statement has no effect (pointless-string-statement)
************* Module bottles.backend.managers.origin
bottles/backend/managers/origin.py:51:28: W0613: Unused argument 'config' (unused-argument)
************* Module bottles.backend.managers.thumbnail
bottles/backend/managers/thumbnail.py:27:0: R0903: Too few public methods (1/2) (too-few-public-methods)
************* Module bottles.backend.managers.ubisoftconnect
bottles/backend/managers/ubisoftconnect.py:80:50: C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
bottles/backend/managers/ubisoftconnect.py:115:30: C0207: Use _path.rsplit('\\', maxsplit=1)[-1] instead (use-maxsplit-arg)
bottles/backend/managers/ubisoftconnect.py:107:16: W0612: Unused variable 'k' (unused-variable)
************* Module bottles.backend.managers.steamgriddb
bottles/backend/managers/steamgriddb.py:34:8: W0702: No exception type(s) specified (bare-except)
bottles/backend/managers/steamgriddb.py:33:18: W3101: Missing timeout argument for method 'requests.get' can cause your program to hang indefinitely (missing-timeout)
bottles/backend/managers/steamgriddb.py:31:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/backend/managers/steamgriddb.py:51:16: W3101: Missing timeout argument for method 'requests.get' can cause your program to hang indefinitely (missing-timeout)
bottles/backend/managers/steamgriddb.py:41:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/backend/managers/steamgriddb.py:29:0: R0903: Too few public methods (1/2) (too-few-public-methods)
************* Module bottles.backend.managers.conf
bottles/backend/managers/conf.py:8:0: R0205: Class 'ConfigManager' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
bottles/backend/managers/conf.py:35:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/conf.py:40:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/conf.py:45:22: W0212: Access to a protected member _sections of a client class (protected-access)
bottles/backend/managers/conf.py:47:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/conf.py:49:17: R1714: Consider merging these comparisons with 'in' by using 'self.config_type in ('yaml', 'yml')'. Use a set instead if elements are hashable. (consider-using-in)
bottles/backend/managers/conf.py:50:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/conf.py:58:22: W0212: Access to a protected member _sections of a client class (protected-access)
bottles/backend/managers/conf.py:61:17: R1714: Consider merging these comparisons with 'in' by using 'self.config_type in ('yaml', 'yml')'. Use a set instead if elements are hashable. (consider-using-in)
bottles/backend/managers/conf.py:76:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/conf.py:81:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/conf.py:94:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/conf.py:98:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise)
bottles/backend/managers/conf.py:103:8: W0105: String statement has no effect (pointless-string-statement)
************* Module bottles.backend.managers.epicgamesstore
bottles/backend/managers/epicgamesstore.py:63:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/epicgamesstore.py:74:30: C0207: Use _path.rsplit('\\', maxsplit=1)[-1] instead (use-maxsplit-arg)
************* Module bottles.backend.managers.runtime
bottles/backend/managers/runtime.py:94:16: W0612: Unused variable 'root' (unused-variable)
bottles/backend/managers/runtime.py:94:28: W0612: Unused variable 'files' (unused-variable)
bottles/backend/managers/runtime.py:124:8: C0415: Import outside toplevel (bottles.backend.managers.steam.SteamManager) (import-outside-toplevel)
************* Module bottles.backend.managers.importer
bottles/backend/managers/importer.py:105:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/managers/importer.py:105:8: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/importer.py:109:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/managers/importer.py:21:0: C0411: standard import "subprocess" should be placed before first party import "bottles.backend.models.config.BottleConfig"  (wrong-import-order)
bottles/backend/managers/importer.py:22:0: C0411: standard import "glob.glob" should be placed before first party import "bottles.backend.models.config.BottleConfig"  (wrong-import-order)
bottles/backend/managers/importer.py:23:0: C0411: standard import "datetime.datetime" should be placed before first party import "bottles.backend.models.config.BottleConfig"  (wrong-import-order)
************* Module bottles.backend.managers.dependency
bottles/backend/managers/dependency.py:83:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:99:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:109:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:123:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:142:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/managers/dependency.py:156:12: W0105: String statement has no effect (pointless-string-statement)
************* Module bottles.backend.managers.sandbox
bottles/backend/managers/sandbox.py:26:4: R0913: Too many arguments (12/5) (too-many-arguments)
bottles/backend/managers/sandbox.py:26:4: R0917: Too many positional arguments (12/5) (too-many-positional-arguments)
************* Module bottles.backend.managers.template
bottles/backend/managers/template.py:56:0: W1404: Implicit string concatenation found in list (implicit-str-concat)
bottles/backend/managers/template.py:73:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/template.py:107:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/template.py:117:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/managers/template.py:182:8: W0612: Unused variable 'copy_func' (unused-variable)
bottles/backend/managers/template.py:22:0: C0411: standard import "uuid" should be placed before first party imports "bottles.backend.models.config.BottleConfig", "bottles.backend.utils.yaml"  (wrong-import-order)
bottles/backend/managers/template.py:23:0: C0411: standard import "shutil" should be placed before first party imports "bottles.backend.models.config.BottleConfig", "bottles.backend.utils.yaml"  (wrong-import-order)
bottles/backend/managers/template.py:24:0: C0411: standard import "contextlib" should be placed before first party imports "bottles.backend.models.config.BottleConfig", "bottles.backend.utils.yaml"  (wrong-import-order)
bottles/backend/managers/template.py:25:0: C0411: standard import "datetime.datetime" should be placed before first party imports "bottles.backend.models.config.BottleConfig", "bottles.backend.utils.yaml"  (wrong-import-order)
bottles/backend/managers/template.py:26:0: C0411: standard import "pathlib.Path" should be placed before first party imports "bottles.backend.models.config.BottleConfig", "bottles.backend.utils.yaml"  (wrong-import-order)
************* Module bottles.backend.wine.register
bottles/backend/wine/register.py:43:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/wine/register.py:64:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/register.py:72:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/register.py:77:20: R1724: Unnecessary "elif" after "continue", remove the leading "el" from "elif" (no-else-continue)
bottles/backend/wine/register.py:78:24: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/register.py:90:24: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/register.py:120:8: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/backend/wine/register.py:145:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/register.py:150:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/wine/register.py:154:12: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/backend/wine/register.py:165:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
************* Module bottles.backend.wine.executor
bottles/backend/wine/executor.py:25:4: R0913: Too many arguments (18/5) (too-many-arguments)
bottles/backend/wine/executor.py:25:4: R0917: Too many positional arguments (18/5) (too-many-positional-arguments)
bottles/backend/wine/executor.py:150:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/backend/wine/executor.py:208:8: E1111: Assigning result of a function call, where the function has no return (assignment-from-no-return)
bottles/backend/wine/executor.py:301:8: E1111: Assigning result of a function call, where the function has no return (assignment-from-no-return)
bottles/backend/wine/executor.py:312:8: E1111: Assigning result of a function call, where the function has no return (assignment-from-no-return)
bottles/backend/wine/executor.py:348:21: W1202: Use lazy % or % formatting in logging functions (logging-format-interpolation)
************* Module bottles.backend.wine.winecommand
bottles/backend/wine/winecommand.py:90:4: W0102: Dangerous default value {} as argument (dangerous-default-value)
bottles/backend/wine/winecommand.py:90:4: R0913: Too many arguments (12/5) (too-many-arguments)
bottles/backend/wine/winecommand.py:90:4: R0917: Too many positional arguments (12/5) (too-many-positional-arguments)
bottles/backend/wine/winecommand.py:143:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:149:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:410:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:414:51: E1136: Value 'gpu['prime']['integrated']' is unsubscriptable (unsubscriptable-object)
bottles/backend/wine/winecommand.py:416:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:462:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:471:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:487:4: R0913: Too many arguments (7/5) (too-many-arguments)
bottles/backend/wine/winecommand.py:487:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
bottles/backend/wine/winecommand.py:523:32: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/wine/winecommand.py:530:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/wine/winecommand.py:539:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/wine/winecommand.py:555:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:560:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:565:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:661:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/wine/winecommand.py:672:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/wine/winecommand.py:710:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
bottles/backend/wine/winecommand.py:731:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
************* Module bottles.backend.wine.regkeys
bottles/backend/wine/regkeys.py:143:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/regkeys.py:294:24: C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
************* Module bottles.frontend.main
bottles/frontend/main.py:31:0: C0413: Import "from gi.repository import Gtk, Gio, GLib, GObject, Adw" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:31:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/main.py:33:0: C0413: Import "from bottles.frontend.params import APP_ID, APP_MAJOR_VERSION, APP_VERSION" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:34:0: C0413: Import "from bottles.backend.logger import Logger" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:35:0: C0413: Import "from bottles.frontend.windows.main_window import MainWindow" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:36:0: C0413: Import "from bottles.frontend.views.preferences import PreferencesWindow" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:37:0: C0413: Import "from bottles.backend.health import HealthChecker" should be placed at the top of the module (wrong-import-position)
bottles/frontend/main.py:48:0: C0103: Constant name "base_dir" doesn't conform to UPPER_CASE naming style (invalid-name)
bottles/frontend/main.py:170:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/main.py:176:12: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/main.py:212:12: C0415: Import outside toplevel (subprocess) (import-outside-toplevel)
bottles/frontend/main.py:214:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/frontend/main.py:218:12: C0415: Import outside toplevel (bottles.frontend.windows.bottlepicker.BottlePickerDialog) (import-outside-toplevel)
bottles/frontend/main.py:264:8: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/main.py:255:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/main.py:267:15: W0613: Unused argument 'action' (unused-argument)
bottles/frontend/main.py:267:28: W0613: Unused argument 'param' (unused-argument)
bottles/frontend/main.py:277:24: W0613: Unused argument 'action' (unused-argument)
bottles/frontend/main.py:277:37: W0613: Unused argument 'param' (unused-argument)
bottles/frontend/main.py:287:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/main.py:291:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/main.py:294:4: W1113: Keyword argument before variable positional arguments list in the definition of __show_importer_view function (keyword-arg-before-vararg)
bottles/frontend/main.py:294:35: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/main.py:294:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/main.py:277:4: W0238: Unused private member `Bottles.__refresh(self, action=None, param=None)` (unused-private-member)
bottles/frontend/main.py:251:8: W0201: Attribute 'win' defined outside __init__ (attribute-defined-outside-init)
bottles/frontend/main.py:389:9: W0613: Unused argument 'version' (unused-argument)
bottles/frontend/main.py:20:0: C0411: standard import "gettext" should be placed before third party import "gi" (wrong-import-order)
bottles/frontend/main.py:21:0: C0411: standard import "locale" should be placed before third party import "gi" (wrong-import-order)
bottles/frontend/main.py:22:0: C0411: standard import "webbrowser" should be placed before third party import "gi" (wrong-import-order)
bottles/frontend/main.py:23:0: C0411: standard import "os.path" should be placed before third party import "gi" (wrong-import-order)
bottles/frontend/main.py:31:0: W0611: Unused Gtk imported from gi.repository (unused-import)
************* Module bottles.frontend.views.library
bottles/frontend/views/library.py:21:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/views/library.py:67:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/views/library.py:72:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/views/library.py:89:22: W0613: Unused argument 'widget' (unused-argument)
************* Module bottles.frontend.views.bottle_preferences
bottles/frontend/views/bottle_preferences.py:1:0: C0302: Too many lines in module (1107/1000) (too-many-lines)
bottles/frontend/views/bottle_preferences.py:487:13: W0511: "vista": "Windows Vista", # TODO: implement this in the backend (fixme)
bottles/frontend/views/bottle_preferences.py:23:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/views/bottle_preferences.py:188:8: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/views/bottle_preferences.py:193:8: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/views/bottle_preferences.py:202:8: W0105: String statement has no effect (pointless-string-statement)
bottles/frontend/views/bottle_preferences.py:317:8: W0212: Access to a protected member __library of a client class (protected-access)
bottles/frontend/views/bottle_preferences.py:326:25: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:383:12: W0612: Unused variable 'index' (unused-variable)
bottles/frontend/views/bottle_preferences.py:585:40: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:589:39: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:593:34: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:597:39: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:612:48: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:616:38: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:620:28: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:624:43: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:629:38: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:654:32: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:660:30: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:666:32: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:672:27: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:678:29: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:695:32: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:701:33: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:707:31: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:713:31: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:719:37: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:725:36: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:731:46: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:763:39: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:772:43: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:781:31: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:807:41: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/views/bottle_preferences.py:852:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1003:19: W0613: Unused argument 'result' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1003:27: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1034:40: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1040:30: W0613: Unused argument 'status' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1040:43: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1052:31: W0613: Unused argument 'status' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1052:44: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1064:31: W0613: Unused argument 'status' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1064:44: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1081:37: W0613: Unused argument 'status' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1081:50: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/views/bottle_preferences.py:1094:17: R1719: The if expression can be replaced with 'not test' (simplifiable-if-expression)
bottles/frontend/views/bottle_preferences.py:317:8: W0238: Unused private member `PreferencesView.__library` (unused-private-member)
bottles/frontend/views/bottle_preferences.py:292:16: W0201: Attribute '__valid_name' defined outside __init__ (attribute-defined-outside-init)
bottles/frontend/views/bottle_preferences.py:295:8: W0201: Attribute '__valid_name' defined outside __init__ (attribute-defined-outside-init)
bottles/frontend/views/bottle_preferences.py:301:12: W0201: Attribute '__valid_name' defined outside __init__ (attribute-defined-outside-init)
bottles/frontend/views/bottle_preferences.py:479:8: W0201: Attribute 'windows_versions' defined outside __init__ (attribute-defined-outside-init)
************* Module bottles.frontend.cli.cli
bottles/frontend/cli/cli.py:34:0: C0103: Constant name "pkgdatadir" doesn't conform to UPPER_CASE naming style (invalid-name)
bottles/frontend/cli/cli.py:36:0: C0103: Constant name "gresource_path" doesn't conform to UPPER_CASE naming style (invalid-name)
bottles/frontend/cli/cli.py:41:0: C0413: Import "from gi.repository import Gio" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:43:0: C0413: Import "from bottles.frontend.params import APP_ID" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:44:0: C0413: Import "from bottles.backend.globals import Paths" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:45:0: C0413: Import "from bottles.backend.health import HealthChecker" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:46:0: C0413: Import "from bottles.backend.managers.manager import Manager" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:47:0: C0413: Import "from bottles.backend.models.config import BottleConfig" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:48:0: C0413: Import "from bottles.backend.wine.cmd import CMD" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:49:0: C0413: Import "from bottles.backend.wine.control import Control" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:50:0: C0413: Import "from bottles.backend.wine.executor import WineExecutor" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:51:0: C0413: Import "from bottles.backend.wine.winecommand import WineCommand" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:52:0: C0413: Import "from bottles.backend.wine.reg import Reg" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:53:0: C0413: Import "from bottles.backend.wine.winepath import WinePath" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:54:0: C0413: Import "from bottles.backend.wine.regedit import Regedit" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:55:0: C0413: Import "from bottles.backend.wine.taskmgr import Taskmgr" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:56:0: C0413: Import "from bottles.backend.wine.uninstaller import Uninstaller" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:57:0: C0413: Import "from bottles.backend.wine.winecfg import WineCfg" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:58:0: C0413: Import "from bottles.backend.wine.explorer import Explorer" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:59:0: C0413: Import "from bottles.backend.wine.regkeys import RegKeys" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:60:0: C0413: Import "from bottles.backend.runner import Runner" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:61:0: C0413: Import "from bottles.backend.utils import json" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:62:0: C0413: Import "from bottles.backend.utils.manager import ManagerUtils" should be placed at the top of the module (wrong-import-position)
bottles/frontend/cli/cli.py:304:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:309:16: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:330:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:360:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:362:8: C0206: Consider iterating with .items() (consider-using-dict-items)
bottles/frontend/cli/cli.py:377:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:385:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:403:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:441:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:449:16: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:457:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:491:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:500:16: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:525:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:535:20: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:564:16: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:574:16: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:584:16: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:594:16: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:650:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:658:16: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:662:16: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:698:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:711:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:730:12: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/cli/cli.py:745:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/frontend/cli/cli.py:239:4: W0238: Unused private member `CLI.__clear()` (unused-private-member)
************* Module bottles.frontend.windows.launchoptions
bottles/frontend/windows/launchoptions.py:18:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/windows/launchoptions.py:190:31: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/launchoptions.py:190:39: W0613: Unused argument 'state' (unused-argument)
bottles/frontend/windows/launchoptions.py:197:50: W0613: Unused argument 'global_value' (unused-argument)
bottles/frontend/windows/launchoptions.py:204:4: R1711: Useless return at end of function or method (useless-return)
bottles/frontend/windows/launchoptions.py:253:19: E1101: Instance of 'Error' has no 'code' member (no-member)
bottles/frontend/windows/launchoptions.py:286:19: E1101: Instance of 'Error' has no 'code' member (no-member)
bottles/frontend/windows/launchoptions.py:28:0: R0903: Too few public methods (1/2) (too-few-public-methods)
bottles/frontend/windows/launchoptions.py:22:0: C0411: standard import "gettext.gettext" should be placed before third party import "gi.repository.Gtk" and first party imports "bottles.backend.utils.manager.ManagerUtils", "bottles.backend.logger.Logger"  (wrong-import-order)
************* Module bottles.frontend.windows.vkbasalt
bottles/frontend/windows/vkbasalt.py:29:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/windows/vkbasalt.py:30:0: E0401: Unable to import 'vkbasalt.lib' (import-error)
bottles/frontend/windows/vkbasalt.py:37:0: R0903: Too few public methods (0/2) (too-few-public-methods)
bottles/frontend/windows/vkbasalt.py:104:12: W0621: Redefining name 'VkBasaltSettings' from outer scope (line 37) (redefined-outer-name)
bottles/frontend/windows/vkbasalt.py:104:12: C0103: Variable name "VkBasaltSettings" doesn't conform to snake_case naming style (invalid-name)
bottles/frontend/windows/vkbasalt.py:119:19: C0121: Comparison 'conf[0] != None' should be 'conf[0] is not None' (singleton-comparison)
bottles/frontend/windows/vkbasalt.py:122:15: C0121: Comparison 'VkBasaltSettings.smaa_edge_detection != None' should be 'VkBasaltSettings.smaa_edge_detection is not None' (singleton-comparison)
bottles/frontend/windows/vkbasalt.py:152:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
bottles/frontend/windows/vkbasalt.py:148:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/windows/vkbasalt.py:179:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/windows/vkbasalt.py:183:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/windows/vkbasalt.py:189:11: C0121: Comparison 'self.check_effects_states() == False' should be 'self.check_effects_states() is False' if checking for the singleton value False, or 'not self.check_effects_states()' if testing for falsiness (singleton-comparison)
bottles/frontend/windows/vkbasalt.py:187:24: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/vkbasalt.py:193:43: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/vkbasalt.py:214:8: R1703: The if statement can be replaced with 'return bool(test)' (simplifiable-if-statement)
bottles/frontend/windows/vkbasalt.py:214:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
bottles/frontend/windows/vkbasalt.py:220:29: C0103: Argument name "VkBasaltSettings" doesn't conform to snake_case naming style (invalid-name)
bottles/frontend/windows/vkbasalt.py:220:29: W0621: Redefining name 'VkBasaltSettings' from outer scope (line 37) (redefined-outer-name)
************* Module bottles.frontend.windows.generic
bottles/frontend/windows/generic.py:18:0: E0611: No name 'GtkSource' in module 'gi.repository' (no-name-in-module)
bottles/frontend/windows/generic.py:18:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/windows/generic.py:42:12: E1101: Instance of 'ScrolledWindow' has no 'append' member (no-member)
bottles/frontend/windows/generic.py:44:12: E1101: Instance of 'MessageDialog' has no 'message_area' member (no-member)
bottles/frontend/windows/generic.py:48:4: R0913: Too many arguments (6/5) (too-many-arguments)
bottles/frontend/windows/generic.py:48:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
bottles/frontend/windows/generic.py:85:8: E1101: Instance of 'HeaderBar' has no 'set_title_widget' member (no-member)
bottles/frontend/windows/generic.py:99:8: E1101: Instance of 'ScrolledWindow' has no 'set_child' member; maybe 'get_child'? (no-member)
bottles/frontend/windows/generic.py:101:8: E1101: Instance of 'Box' has no 'append' member (no-member)
bottles/frontend/windows/generic.py:102:8: E1101: Instance of 'Box' has no 'append' member (no-member)
bottles/frontend/windows/generic.py:107:20: E1101: Class 'Display' has no 'get_clipboard' member (no-member)
bottles/frontend/windows/generic.py:106:26: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/generic.py:47:0: R0903: Too few public methods (0/2) (too-few-public-methods)
bottles/frontend/windows/generic.py:138:8: E1101: Instance of 'ScrolledWindow' has no 'set_child' member; maybe 'get_child'? (no-member)
bottles/frontend/windows/generic.py:140:8: E1101: Instance of 'Box' has no 'append' member (no-member)
bottles/frontend/windows/generic.py:141:8: E1101: Instance of 'Box' has no 'append' member (no-member)
bottles/frontend/windows/generic.py:146:20: E1101: Class 'Display' has no 'get_clipboard' member (no-member)
bottles/frontend/windows/generic.py:145:26: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/generic.py:111:0: R0903: Too few public methods (0/2) (too-few-public-methods)
bottles/frontend/windows/generic.py:181:8: E0602: Undefined variable 'webview' (undefined-variable)
bottles/frontend/windows/generic.py:184:8: E1101: Instance of 'Box' has no 'append' member (no-member)
bottles/frontend/windows/generic.py:185:8: E1101: Instance of 'Box' has no 'append' member (no-member)
bottles/frontend/windows/generic.py:190:20: E1101: Class 'Display' has no 'get_clipboard' member (no-member)
bottles/frontend/windows/generic.py:189:26: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/generic.py:150:0: R0903: Too few public methods (0/2) (too-few-public-methods)
bottles/frontend/windows/generic.py:19:0: C0411: standard import "gettext.gettext" should be placed before third party import "gi.repository.Gtk" (wrong-import-order)
************* Module bottles.frontend.windows.generic_cli
bottles/frontend/windows/generic_cli.py:3:14: W0613: Unused argument 'parent' (unused-argument)
bottles/frontend/windows/generic_cli.py:3:22: W0613: Unused argument 'title' (unused-argument)
bottles/frontend/windows/generic_cli.py:3:73: W0613: Unused argument 'log' (unused-argument)
bottles/frontend/windows/generic_cli.py:1:0: R0903: Too few public methods (0/2) (too-few-public-methods)
************* Module bottles.frontend.windows.main_window
bottles/frontend/windows/main_window.py:24:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/windows/main_window.py:24:0: E0611: No name 'Xdp' in module 'gi.repository' (no-name-in-module)
bottles/frontend/windows/main_window.py:106:20: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/windows/main_window.py:104:25: W0613: Unused argument 'dialog' (unused-argument)
bottles/frontend/windows/main_window.py:104:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/windows/main_window.py:170:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/windows/main_window.py:197:35: W0613: Unused argument 'status' (unused-argument)
bottles/frontend/windows/main_window.py:214:41: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/windows/main_window.py:320:32: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/main_window.py:324:32: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/main_window.py:328:32: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/main_window.py:335:28: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/main_window.py:339:29: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/main_window.py:342:33: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/main_window.py:345:30: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/main_window.py:345:44: W0613: Unused argument 'view' (unused-argument)
bottles/frontend/windows/main_window.py:360:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/frontend/windows/main_window.py:384:4: R0913: Too many arguments (6/5) (too-many-arguments)
bottles/frontend/windows/main_window.py:384:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
bottles/frontend/windows/main_window.py:398:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/windows/main_window.py:414:0: W0613: Unused argument 'args' (unused-argument)
bottles/frontend/windows/main_window.py:421:8: R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
bottles/frontend/windows/main_window.py:424:17: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/windows/main_window.py:224:12: W0201: Attribute 'page_details' defined outside __init__ (attribute-defined-outside-init)
bottles/frontend/windows/main_window.py:225:12: W0201: Attribute 'page_list' defined outside __init__ (attribute-defined-outside-init)
bottles/frontend/windows/main_window.py:226:12: W0201: Attribute 'page_importer' defined outside __init__ (attribute-defined-outside-init)
bottles/frontend/windows/main_window.py:227:12: W0201: Attribute 'page_library' defined outside __init__ (attribute-defined-outside-init)
bottles/frontend/windows/main_window.py:54:0: R0904: Too many public methods (25/20) (too-many-public-methods)
************* Module bottles.frontend.widgets.component
bottles/frontend/widgets/component.py:97:45: W0511: TODO: unimplemented (fixme)
bottles/frontend/widgets/component.py:21:0: E0611: No name 'Adw' in module 'gi.repository' (no-name-in-module)
bottles/frontend/widgets/component.py:90:35: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/widgets/component.py:88:23: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/component.py:110:27: W0613: Unused argument 'error' (unused-argument)
bottles/frontend/widgets/component.py:108:24: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/component.py:126:25: W0613: Unused argument 'widget' (unused-argument)
bottles/frontend/widgets/component.py:133:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
bottles/frontend/widgets/component.py:181:0: R0903: Too few public methods (0/2) (too-few-public-methods)
************* Module bottles.frontend.widgets.executable
bottles/frontend/widgets/executable.py:34:25: W0613: Unused argument 'widget' (unused-argument)

@mirkobrombin
Copy link
Member

Why not?

@TheEvilSkeleton TheEvilSkeleton enabled auto-merge (rebase) December 19, 2024 00:34
@TheEvilSkeleton TheEvilSkeleton merged commit 0c07176 into bottlesdevs:main Dec 19, 2024
5 checks passed
@TheEvilSkeleton TheEvilSkeleton deleted the pre-commit branch December 19, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants