Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop aws-k8s-1.23 settings and plugins #4237

Merged

Conversation

ginglis13
Copy link
Contributor

@ginglis13 ginglis13 commented Oct 7, 2024

Issue number:

Related: #4083

Description of changes:

Follow up from #4227 (comment) to remove aws-k8s-1.23 settings and settings plugins

Also update some docs that refer to k8s-1.23

Testing done:

for variant in aws-k8s-1.24 aws-k8s-1.24-nvidia; do  
  for arch in aarch64 x86_64; do
        cargo make \
                   -e BUILDSYS_ARCH=$arch \
                  -e BUILDSYS_VARIANT=$variant
  done
done

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Update some docs to refer to newer k8s variants.

Signed-off-by: Gavin Inglis <[email protected]>
Copy link
Contributor

@koooosh koooosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the follow-up

@ginglis13 ginglis13 merged commit 40e1e65 into bottlerocket-os:develop Oct 8, 2024
2 checks passed
@ginglis13 ginglis13 mentioned this pull request Oct 9, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants