Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix locking on ending execution #8

Merged
merged 1 commit into from
Jun 25, 2023
Merged

fix locking on ending execution #8

merged 1 commit into from
Jun 25, 2023

Conversation

withinboredom
Copy link
Contributor

closes #2

@withinboredom withinboredom enabled auto-merge (squash) June 25, 2023 20:55
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: +0.16 🎉

Comparison is base (b51d08a) 32.12% compared to head (f168a7c) 32.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main       #8      +/-   ##
============================================
+ Coverage     32.12%   32.28%   +0.16%     
- Complexity      752      754       +2     
============================================
  Files            70       70              
  Lines          2310     2317       +7     
============================================
+ Hits            742      748       +6     
- Misses         1568     1569       +1     
Impacted Files Coverage Δ
src/State/OrchestrationHistory.php 76.99% <33.33%> (-2.45%) ⬇️
src/OrchestrationContext.php 69.95% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@withinboredom withinboredom merged commit 7fc6e52 into main Jun 25, 2023
@withinboredom withinboredom deleted the fix/unlocking branch June 25, 2023 20:57
withinboredom added a commit that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locks aren't released on failure
1 participant