Handle case when s3 config key is not a dict #858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression for the error case when a user
has an invalid CLI config file. Examples include:
Previously, we would check that the 's3' key was a dict type
before trying to access values. This puts back the old
behavior.
Long term, we're going to need something that properly validates
the config keys and gives good error messages for these conditions.
Without this change you'd get this:
cc @kyleknap @JordonPhillips