Handle the case where we receive a generic html error response #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesls
force-pushed
the
fix-response-metadata
branch
from
ba00ba7 to
7700cd6
Compare
Fixes boto/boto3#339. I also had to fix an unrelated test because the response body is always read as bytes(), and two of the functional tests were using str().
jamesls
force-pushed
the
fix-response-metadata
branch
from
7700cd6 to
afe0ace
Compare
|
What do you think about populating those values with the HTTP error codes? Otherwise CLI users are not going to have any idea what just happened. |
Give the user some idea of what went wrong.
|
@JordonPhillips feedback incorporated. |
|
⛵ |
|
Looks good. 🚢 Do you think that this fix also partially resolves this issue: aws/aws-cli#1679 for when the proxy returns straight html? |
|
@kyleknap It should. Looking at their output it looks like this should fix that case because we're getting an HTML error page back from the proxy. Excellent. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes boto/boto3#339.
cc @kyleknap @JordonPhillips