Don't remove lazy component from deferred until success #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only delete the component from the deferred dict after successfully creating the object from the factory as well as injecting the instantiated value into the _components dict. The bug is that is the factory object raises an exception, we've already removed it from the deferred list (via the .pop() call), but we haven't added anything to the _components dict. Because of this, the next time you try to make a call you'll get an error message about an unknown component. It also looks like there were no unit tests for this class. It was only tested transitively before. I've added a set of unit tests covering this behavior.
jamesls
added
the
pr/needs-review
|
Looks good. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only delete the component from the deferred dict after
successfully creating the object from the factory as well as
injecting the instantiated value into the _components dict.
The bug is that is the factory object raises an exception,
we've already removed it from the deferred list (via the
.pop() call), but we haven't added anything to the _components
dict.
Because of this, the next time you try to make a call you'll
get an error message about an unknown component.
It also looks like there were no unit tests for this class.
It was only tested transitively before. I've added a set
of unit tests covering this behavior.
This was found while looking into aws/aws-cli#1515
cc @kyleknap @mtdowling @rayluo