Upgrade Requests dependency to 2.5.1 #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In newer versions of requests, the Authorization header is removed if a redirect occurs where the new host does not equal the original host. In the case of S3 redirects, we know that this is ok so we need to add back the old behavior. We do this by subclassing the session and overriding its rebuild_auth() class to be a no-op. That is, it just keeps the auth from the original request.
|
Should also fix #266 |
|
LGTM 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest request release. It was relatively painless, with the exception of one change to how redirects are handled.
Only new change I added is jamesls@0c9790d
Verified clean runs of the botocore/aws-cli unit and integration tests.
cc @kyleknap @danielgtaylor