Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waiters for elasticache #443

Merged
merged 2 commits into from
Jan 29, 2015
Merged

Add waiters for elasticache #443

merged 2 commits into from
Jan 29, 2015

Conversation

Jc2k
Copy link
Contributor

@Jc2k Jc2k commented Jan 26, 2015

This adds 4 new waiters i've needed recently. I've used the same delays/attempts as RDS, which works for me quite well so far.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.1% when pulling 8c5987c on Jc2k:cache-waiters into 4a2163f on boto:develop.

@jamesls
Copy link
Member

jamesls commented Jan 27, 2015

Thanks for adding these. The one thing I'd suggest changing is instead of using the 404 status code checker we use the error code returned by the service. There was a bug in botocore that prevented us from using this before, but this issue is now fixed. For example here's this change for RDS (https://github.com/boto/botocore/blob/develop/botocore/data/aws/rds/2014-10-31.waiters.json#L64-L68).

@Jc2k
Copy link
Contributor Author

Jc2k commented Jan 27, 2015

I saw you released the fix for that, and so quickly too! Cheers! I've made the change you requested.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.12% when pulling de25c9b on Jc2k:cache-waiters into 4a2163f on boto:develop.

@jamesls jamesls merged commit de25c9b into boto:develop Jan 29, 2015
@jamesls
Copy link
Member

jamesls commented Jan 29, 2015

Merged, thanks!

@Jc2k Jc2k deleted the cache-waiters branch January 29, 2015 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants