Allow idempotent request signing #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where request signing is not idempotent. This is because setting a header value does not replace the old value, it actually appends the new value to a list of values associated with the header name. This causes issue when the same request is retried, particularly with S3 retries.
|
LGTM 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where request signing is not
idempotent. This is because setting a header
value does not replace the old value, it actually
appends the new value to a list of values associated
with the header name. This causes issue when the
same request is retried, particularly with S3 retries.
This fixes the signature errors we've been seeing in
the integration tests.
cc @kyleknap @danielgtaylor