fix V2 auth timestamp #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amazon describes common header parameters here - http://docs.aws.amazon.com/AWSEC2/latest/APIReference/Query-Common-Parameters.html Timestamp should be in ISO8601 format. But datetime.isoformat() generates string in format that not compatible with ISO8601. I prefer to copy this from requestbuilder that used by euca2ools.
|
Thanks for the PR. As per our contributing guidelines could you add a testcase for this change that demonstrates the problem? |
|
I've created a simple test that checks fields returned by add_auth method. |
jamesls
added a commit
that referenced
this pull request
Jun 24, 2014
* Andrey-mp-develop: add test for #308 fix V2 auth timestamp
|
Merged, thanks! |
jamesls
added a commit
that referenced
this pull request
Jun 25, 2014
* release-0.53.0: Bumping version to 0.53.0 Update SES model to the latest version Fix regression in EC2 credential provider parsing Fix region endpoint for cn-north-1 add test for #308 fix V2 auth timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon describes common header parameters here -
http://docs.aws.amazon.com/AWSEC2/latest/APIReference/Query-Common-Parameters.html
Timestamp should be in ISO8601 format. But datetime.isoformat() generates
string in format that not compatible with ISO8601.
This fact make botocore incompatible with Openstack implementation of Amazon
REST API (but euca2ools and boto work well with Openstack)
So I prefer to copy this from requestbuilder that used by euca2ools.